Page MenuHomePhabricator
Differential D18146

qt: don't pass config to BitcoinApplication::requestShutdown
ClosedPublic
Actions

Authored by PiRK on May 26 2025, 08:34.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC076cec51f98f: qt: don't pass config to BitcoinApplication::requestShutdown
Summary

This was added in D292 but AFAICT it was never used in this function.

Test Plan

ninja check

run bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.May 26 2025, 08:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2025, 08:34
PiRK requested review of this revision.May 26 2025, 08:34
PiRK retitled this revision from gui: don't pass config to BitcoinApplication::requestShutdown to qt: don't pass config to BitcoinApplication::requestShutdown.May 26 2025, 08:54
PiRK added a child revision: D18149: gui: replace some QDialog::exec() with safer QDialog::show() calls.May 26 2025, 09:00
Harbormaster completed remote builds in B33433: Diff 54175.May 26 2025, 09:10
Fabien accepted this revision.May 26 2025, 09:30
This revision is now accepted and ready to land.May 26 2025, 09:30
Closed by commit rABC076cec51f98f: qt: don't pass config to BitcoinApplication::requestShutdown (authored by PiRK). · Explain WhyMay 26 2025, 13:35
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC076cec51f98f: qt: don't pass config to BitcoinApplication::requestShutdown.

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
4 lines
test/
2 lines

Diff 54190

View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...