Page MenuHomePhabricator
Differential D292

Addresses hang issue seen in T28 by freetrader -- properly register Config type with Qt so it may be used in signals/slots
ClosedPublic
Actions

Authored by CCulianu on Jul 3 2017, 11:31.

Details

Reviewers
deadalnix
freetrader
sickpig
kyuupichan
awemany
Group Reviewers
Restricted Project
Restricted Owners Package(Owns No Changed Paths)
Maniphest Tasks
Restricted Maniphest Task
Commits
rSTAGINGa78d5cbd3a89: Addresses hang issue seen in T28 by freetrader -- properly register Config type…
rABCa78d5cbd3a89: Addresses hang issue seen in T28 by freetrader -- properly register Config type…
Summary

T28 issue was that passing Config object around confused Qt's type system so initialize() slot was never invoked. This fixes it to work.

Test Plan

build with Qt and run src/qt/bitcoin-qt. If it gets past splash screen without hanging, it works.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

CCulianu created this revision.Jul 3 2017, 11:31
Owners added a reviewer: Restricted Owners Package.Jul 3 2017, 11:31
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptJul 3 2017, 11:31
deadalnix edited edge metadata.Jul 3 2017, 12:12

We should just trash the whole qt interface instead of trying to fix it.

freetrader edited edge metadata.Jul 3 2017, 15:00

I've tested this using a build with Qt4 and it works on my system.
I'll try building on older Ubuntu to see if its ok there too.

I like the good explanatory comments in this diff.

CCulianu added a comment.Jul 4 2017, 12:50

Ok sounds good guys. Let me know if I should land it.

@deadalnix -- understood about trashing UI ... this is here in case freetrader wants to keep these changes until we *DO* trash the UI.. am ok with whatever.

freetrader accepted this revision.Jul 4 2017, 18:26

Travis tests OK (ignoring the well known Wine issue)

I'm accepting this for now. It might be a shortlived patch while the GUI is removed in the near future.

This revision is now accepted and ready to land.Jul 4 2017, 18:26
Closed by commit rABCa78d5cbd3a89: Addresses hang issue seen in T28 by freetrader -- properly register Config type… (authored by CCulianu, committed by CCulianu). · Explain WhyJul 4 2017, 18:28
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
qt/
59 lines

Diff 737

View Options

src/qt/bitcoin.cpp

Loading...