Page MenuHomePhabricator
Differential D18175

[e.cash] Capitalize Internet for v2 site
ClosedPublic
Actions

Authored by Mengerian on May 30 2025, 17:15.

Details

Reviewers
bytesofman
Fabien
Group Reviewers
Restricted Project
Commits
rABCba5ee5acf062: [e.cash] Capitalize Internet for v2 site
Summary

Internet is typically capitalized

Test Plan

Run locally, looks good

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-v2-capitalize-Internet
Lint
Lint Errors
SeverityLocationCodeMessage
Errorweb/e.cash_v2/app/page.tsx:PRETTIERLinter error
Unit
No Test Coverage
Build Status
Buildable 33481
Build 66441: Build Diff
Build 66440: arc lint + arc unit

Event Timeline

Mengerian created this revision.May 30 2025, 17:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 30 2025, 17:15
Mengerian requested review of this revision.May 30 2025, 17:15
Harbormaster completed remote builds in B33481: Diff 54258.May 30 2025, 17:15
bytesofman requested changes to this revision.May 30 2025, 17:21
bytesofman added a subscriber: bytesofman.

you'll need to run npm ci on your local machine for arc lint to work properly

This revision now requires changes to proceed.May 30 2025, 17:21
bytesofman added a comment.May 30 2025, 17:22

@bot preview-e.cash_v2

teamcity awarded a token.May 30 2025, 17:32

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash_v2) passed.
Preview is available at http://51.68.37.192:41963 for the next 60 minutes.

Mengerian updated this revision to Diff 54260.May 30 2025, 18:51

Fix lint issue

Harbormaster completed remote builds in B33483: Diff 54260.May 30 2025, 18:51
Fabien accepted this revision.May 30 2025, 19:58
Fabien added a comment.May 30 2025, 20:03

Macro internet:

bytesofman accepted this revision.May 30 2025, 20:34
This revision is now accepted and ready to land.May 30 2025, 20:34
Closed by commit rABCba5ee5acf062: [e.cash] Capitalize Internet for v2 site (authored by Mengerian). · Explain WhyMay 31 2025, 01:37
This revision was automatically updated to reflect the committed changes.
Mengerian added a commit: rABCba5ee5acf062: [e.cash] Capitalize Internet for v2 site.
Idan-Neeman added a subscriber: Idan-Neeman.Jun 3 2025, 16:01
This comment was removed by Idan-Neeman.

Revision Contents
Changeset List

PathSize
web/
e.cash_v2/
app/
2 lines

Diff 54258

View Options

web/e.cash_v2/app/page.tsx

Loading...