Differential D18198

qt: Fix linking when configured with `-DENABLE_WALLET=OFF`
ClosedPublic
Actions

Authored by PiRK on Jun 4 2025, 08:14.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCec0feb99b332: qt: Fix linking when configured with `-DENABLE_WALLET=OFF`

Summary

This change is required for Qt 6, but it is meaningful on its own.
This is a backport of core-gui#837

Test Plan

With changes in the cmake config to use Qt 6:

cmake .. -GNinja -DBUILD_BITCOIN_WALLET=0
ninja

Without this change:

/usr/include/x86_64-linux-gnu/qt6/QtCore/qmetatype.h:903: error: undefined reference to 'WalletModel::staticMetaObject'
/usr/include/x86_64-linux-gnu/qt6/QtCore/qmetatype.h:1313: error: undefined reference to 'WalletModel::staticMetaObject'
collect2: error: ld returned 1 exit status

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 4 2025, 08:14

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2025, 08:14

PiRK requested review of this revision.Jun 4 2025, 08:14

teamcity edited the summary of this revision. (Show Details)Jun 4 2025, 08:15

PiRK edited the test plan for this revision. (Show Details)Jun 4 2025, 08:15

PiRK added a child revision: D18199: qt6: Handle deprecated `QLocale::nativeCountryName`.Jun 4 2025, 08:23

Harbormaster completed remote builds in B33525: Diff 54327.Jun 4 2025, 08:27

Fabien accepted this revision.Jun 4 2025, 11:15

This revision is now accepted and ready to land.Jun 4 2025, 11:15

Closed by commit rABCec0feb99b332: qt: Fix linking when configured with `-DENABLE_WALLET=OFF` (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJun 4 2025, 12:23

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCec0feb99b332: qt: Fix linking when configured with `-DENABLE_WALLET=OFF`.

Revision Contents
Changeset List

Path

Size

src/

qt/

2 lines

Diff 54332

src/qt/rpcconsole.cpp

Loading...