Page MenuHomePhabricator
Differential D18200

qt6, test: Handle deprecated code
ClosedPublic
Actions

Authored by PiRK on Jun 4 2025, 08:42.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC10e8feea4ccd: qt6, test: Handle deprecated code
Summary

qt6, test: Use qWarning() instead of QWARN() macro

The QWARN() macro internally uses QTest::qWarn(), which has been
deprecated since Qt 6.3. Replacing it with qWarning() ensures
compatibility across all Qt versions.

qt6, test: Handle deprecated QVERIFY_EXCEPTION_THROWN

This change ensures compatibility across all supported Qt versions.

Co-Authored-By: João Barbosa <joao.paulo.barbosa@gmail.com>

This is a backport of core-gui#839
Depends on D18199

Test Plan

ninja check
With Qt6.4, verify the lack of deprecation warnings when compiling

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Jun 4 2025, 08:42
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2025, 08:42
PiRK requested review of this revision.Jun 4 2025, 08:42
teamcity edited the summary of this revision. (Show Details)Jun 4 2025, 08:42
PiRK added inline comments.Jun 4 2025, 08:44
src/qt/test/test_main.cpp
69–72 ↗(On Diff #54329)

added in core#27302
It doesn't hurt to add it here as well, even without the actual bugfix from the PR

Harbormaster completed remote builds in B33527: Diff 54329.Jun 4 2025, 08:58
PiRK added a child revision: D18201: qt6: Handle different signatures of `QANEF::nativeEventFilter`.Jun 4 2025, 09:01
Fabien accepted this revision.Jun 4 2025, 11:18
This revision is now accepted and ready to land.Jun 4 2025, 11:18
Closed by commit rABC10e8feea4ccd: qt6, test: Handle deprecated code (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by PiRK). · Explain WhyJun 4 2025, 12:23
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC10e8feea4ccd: qt6, test: Handle deprecated code.
PiRK mentioned this in D18204: qt: fix broken unit tests on MacOS.Jun 5 2025, 07:20
PiRK mentioned this in D18205: gui: add test runner summary.Jun 5 2025, 07:22
PiRK mentioned this in rABC13439b515b96: qt: fix broken unit tests on MacOS.Jun 5 2025, 08:28
PiRK mentioned this in rABCf67e5f1af4d6: gui: add test runner summary.
Fabien mentioned this in D18213: Unbreak the MacOS tests.Jun 6 2025, 08:13
Fabien mentioned this in rABC5d0d2ee337b4: Unbreak the MacOS tests.Jun 6 2025, 09:29

Revision Contents
Changeset List

PathSize
src/
qt/
test/
9 lines
8 lines
6 lines
5 lines
9 lines

Diff 54334

View Options

src/qt/test/addressbooktests.cpp

Loading...
View Options

src/qt/test/apptests.cpp

Loading...
View Options

src/qt/test/rpcnestedtests.cpp

Loading...
View Options

src/qt/test/test_main.cpp

Loading...
View Options

src/qt/test/wallettests.cpp

Loading...