Paths

Table of Contentst

Differential D1819

gui: Drop qt4 support
ClosedPublic
Actions

Authored by deadalnix on Sep 27 2018, 10:51.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING9c6d605e9ef6: gui: Drop qt4 support
rABC9c6d605e9ef6: gui: Drop qt4 support

Summary

build: Build system changes to support only Qt5

gui: Remove QT_VERSION fallbacks for Qt < 5

There were surprisingly many #ifdef fallbacks for Qt 4.

Remiving them simplifies maintenance, as well as adding new GUI
functionality.

doc: Remove mention of Qt4 from build docs

This is a backport of core's PR13458

Depends on D1802 and D1818

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

onlyqt5

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3404
Build 4885: Bitcoin ABC Buildbot (legacy)
Build 4884: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 27 2018, 10:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2018, 10:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3404: Diff 5099.Sep 27 2018, 11:08

deadalnix added a child revision: D1820: depends: Upgrade Qt to 5.9.6.Sep 27 2018, 13:01

Great backport :)

This revision is now accepted and ready to land.Sep 27 2018, 17:43

Closed by commit rABC9c6d605e9ef6: gui: Drop qt4 support (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by deadalnix). · Explain WhySep 27 2018, 17:52

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

build-aux/

m4/

bitcoin_qt.m4

237 lines

configure.ac

3 lines

doc/

build-unix.md

11 lines

release-notes.md

1 line

src/

qt/

9 lines

8 lines

42 lines

16 lines

coincontroldialog.cpp

6 lines

guiutil.h

2 lines

guiutil.cpp

33 lines

macdockiconhandler.mm

8 lines

networkstyle.cpp

4 lines

openuridialog.cpp

2 lines

optionsdialog.cpp

20 lines

paymentrequestplus.cpp

2 lines

paymentserver.cpp

19 lines

peertablemodel.cpp

2 lines

receiverequestdialog.cpp

3 lines

rpcconsole.cpp

4 lines

sendcoinsentry.cpp

2 lines

signverifymessagedialog.cpp

2 lines

test/

test_main.cpp

7 lines

transactionview.cpp

4 lines

winshutdownmonitor.h

2 lines

winshutdownmonitor.cpp

6 lines

Diff 5099

View Options

build-aux/m4/bitcoin_qt.m4

View Options

configure.ac

View Options

doc/build-unix.md

View Options

doc/release-notes.md

View Options

src/qt/addressbookpage.cpp

View Options

src/qt/bantablemodel.cpp

View Options

src/qt/bitcoin.cpp

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/coincontroldialog.cpp

View Options

src/qt/guiutil.h

View Options

src/qt/guiutil.cpp

View Options

src/qt/macdockiconhandler.mm

View Options

src/qt/networkstyle.cpp

View Options

src/qt/openuridialog.cpp

View Options

src/qt/optionsdialog.cpp

View Options

src/qt/paymentrequestplus.cpp

View Options

src/qt/paymentserver.cpp

View Options

src/qt/peertablemodel.cpp

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/rpcconsole.cpp

View Options

src/qt/sendcoinsentry.cpp

View Options

src/qt/signverifymessagedialog.cpp

View Options

src/qt/test/test_main.cpp

View Options

src/qt/transactionview.cpp

View Options

src/qt/winshutdownmonitor.h

View Options

src/qt/winshutdownmonitor.cpp

gui: Drop qt4 supportClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5099

build-aux/m4/bitcoin_qt.m4

configure.ac

doc/build-unix.md

doc/release-notes.md

src/qt/addressbookpage.cpp

src/qt/bantablemodel.cpp

src/qt/bitcoin.cpp

src/qt/bitcoingui.cpp

src/qt/coincontroldialog.cpp

src/qt/guiutil.h

src/qt/guiutil.cpp

src/qt/macdockiconhandler.mm

src/qt/networkstyle.cpp

src/qt/openuridialog.cpp

src/qt/optionsdialog.cpp

src/qt/paymentrequestplus.cpp

src/qt/paymentserver.cpp

src/qt/peertablemodel.cpp

src/qt/receiverequestdialog.cpp

src/qt/rpcconsole.cpp

src/qt/sendcoinsentry.cpp

src/qt/signverifymessagedialog.cpp

src/qt/test/test_main.cpp

src/qt/transactionview.cpp

src/qt/winshutdownmonitor.h

src/qt/winshutdownmonitor.cpp

gui: Drop qt4 support
ClosedPublic
Actions

Revision Contents
Changeset List