Page MenuHomePhabricator
Differential D18203

[Cashtab] Update rendering for fees on FIRMA-USDT redeems
ClosedPublic
Actions

Authored by bytesofman on Jun 4 2025, 22:10.

Details

Reviewers
Fabien
emack
Group Reviewers
Restricted Project
Commits
rABCe30193975837: [Cashtab] Update rendering for fees on FIRMA-USDT redeems
Summary

Fees are not a constant $2, but min $2 and 1% on amounts > $200.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
firma-redeem-fees
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/components/Send/helpers/index.test.ts:8ESLINT@typescript-eslint/no-unused-vars
Unit
No Test Coverage
Build Status
Buildable 33539
Build 66557: Build Diffcashtab-tests
Build 66556: arc lint + arc unit

Event Timeline

bytesofman created this revision.Jun 4 2025, 22:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 4 2025, 22:10
Harbormaster completed remote builds in B33539: Diff 54349.Jun 4 2025, 22:10
bytesofman updated this revision to Diff 54350.Jun 4 2025, 22:11

lint

bytesofman updated this revision to Diff 54351.Jun 4 2025, 22:14

better comments

Harbormaster completed remote builds in B33540: Diff 54350.Jun 4 2025, 22:16
Harbormaster completed remote builds in B33541: Diff 54351.Jun 4 2025, 22:19
bytesofman published this revision for review.Jun 4 2025, 22:29
Fabien accepted this revision.Jun 5 2025, 07:23
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/src/components/Send/helpers/index.ts
44 ↗(On Diff #54351)
This revision is now accepted and ready to land.Jun 5 2025, 07:23
emack accepted this revision.Jun 5 2025, 07:25
Closed by commit rABCe30193975837: [Cashtab] Update rendering for fees on FIRMA-USDT redeems (authored by bytesofman). · Explain WhyJun 5 2025, 12:44
This revision was automatically updated to reflect the committed changes.
bytesofman marked an inline comment as done.
bytesofman added a commit: rABCe30193975837: [Cashtab] Update rendering for fees on FIRMA-USDT redeems.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Send/
12 lines
helpers/
25 lines
17 lines
constants/
14 lines

Diff 54349

View Options

cashtab/src/components/Send/SendXec.tsx

Loading...
View Options

cashtab/src/components/Send/helpers/index.test.ts

Loading...
View Options

cashtab/src/components/Send/helpers/index.ts

Loading...
View Options

cashtab/src/constants/tokens.ts

Loading...