Differential D18207

Test framework: fix the MiniWallet fee rate calculation
ClosedPublic
Actions

Authored by Fabien on Jun 5 2025, 12:41.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCae110d0a56e8: Test framework: fix the MiniWallet fee rate calculation

Summary

If the target_size parameter is set, the fee_rate parameter is not used correctly.

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_feerate

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33546
Build 66571: Build Diff	build-diff · build-clang · build-without-wallet · build-clang-tidy · build-debug
Build 66570: arc lint + arc unit

Event Timeline

Fabien created this revision.Jun 5 2025, 12:41

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 5 2025, 12:41

Fabien requested review of this revision.Jun 5 2025, 12:41

Harbormaster completed remote builds in B33546: Diff 54358.Jun 5 2025, 12:55

PiRK accepted this revision.Jun 5 2025, 15:40

This revision is now accepted and ready to land.Jun 5 2025, 15:40

Closed by commit rABCae110d0a56e8: Test framework: fix the MiniWallet fee rate calculation (authored by Fabien). · Explain WhyJun 5 2025, 18:17

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCae110d0a56e8: Test framework: fix the MiniWallet fee rate calculation.

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

wallet.py

2 lines

Diff 54358

View Options

test/functional/test_framework/wallet.py

Test framework: fix the MiniWallet fee rate calculationClosedPublicActions