Rename register.h header guard
ClosedPublic
Actions

Authored by jasonbcox on Sep 27 2018, 22:47.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGINGfb6675861ba9: Rename register.h header guard
rABCfb6675861ba9: Rename register.h header guard

Summary

Rename the header guard because _RPC_ indicates the package/directory that it resides in, so it should not be conjoined to the REGISTER_H portion.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

reg

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3426
Build 4928: Bitcoin ABC Buildbot (legacy)
Build 4927: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Sep 27 2018, 22:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 27 2018, 22:47

jasonbcox mentioned this in D1721: Added RPCServer and defined its API, wrapping the old implementation.Sep 27 2018, 22:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3426: Diff 5145.Sep 27 2018, 23:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Sep 28 2018, 15:23

This revision is now accepted and ready to land.Sep 28 2018, 15:23

Closed by commit rABCfb6675861ba9: Rename register.h header guard (authored by jasonbcox). · Explain WhySep 28 2018, 17:30

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

rpc/

6 lines

Diff 5145

View Options

Rename register.h header guardClosedPublicActions