Page MenuHomePhabricator

Move ContextualCheckTransactionForCurrentBlock to tx_verify.h/cpp
ClosedPublic

Authored by Fabien on Jul 15 2025, 10:31.

Details

Summary

The other interface ContextualCheckTransaction is already here so this is where it belongs. This will make it possible to call the checks from the mempool without introducing a circular dependency.

The documentation for the function has been updated to remove an out-of-date comment. There is no change in behavior.

Test Plan
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
move_contextual_check_tx_for_block
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 33876
Build 67225: Build Difflint-circular-dependencies · build-diff · build-without-wallet · build-debug · build-clang · build-clang-tidy
Build 67224: arc lint + arc unit