This makes it possible to build a transaction from the raw hex.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABCf4de7e80c68c: [ecash-lib] Add a Tx deserialization method
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- master
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
| modules/ecash-lib/package.json | ||
|---|---|---|
| 3 | keep min mind that when the stacked diff is landed, we will skip publishing 4.1.0 and publish 4.2.0 imo this is fine, just worth noting. | |
| modules/ecash-lib/src/tx.test.ts | ||
| 127 | it is nice to have a generic test here, but would be helpful to see this happen with a real rawtx as well, something that's been broadcast and is on the blockchain | |
| 174 | not sure why we need this Buffer.from(<bytes>).toString('hex') -- can we not use ecash-lib's toHex? | |
| 227 | if it's worth testing this behavior, we should add the specific error msg we expect from each of these instead of a generic "we expect it to throw" test | |
| modules/ecash-lib/package.json | ||
|---|---|---|
| 3 | If the next diff is accepted, yes. I don't think I need to assume it would be nor hold on releasing this version which is useful on its own. | |