[ecash-lib] Add txid computation from the Tx object
ClosedPublic
Actions

Authored by Fabien on Jul 21 2025, 14:06.

Details

Reviewers

bytesofman

Group Reviewers

Restricted Project

Commits

rABC59d8b9fd610e: [ecash-lib] Add txid computation from the Tx object

Summary

In order to efficiently use the txid subscription from chronik we need to compute this txid. Doing so makes it possible to get the tx added to mempool event from chronik after it is broadcast.

Depends on D18393.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 21 2025, 14:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 21 2025, 14:06

Update the version and the changelog in the readme

Harbormaster completed remote builds in B33927: Diff 54930.Jul 21 2025, 14:16

Harbormaster completed remote builds in B33928: Diff 54931.Jul 21 2025, 14:20

Fabien added a child revision: D18396: [ecash-lib] Export Tx.toHex().Jul 21 2025, 21:24

bytesofman requested changes to this revision.Jul 22 2025, 10:32

bytesofman added a subscriber: bytesofman.

bytesofman added inline comments.

modules/ecash-lib/src/tx.test.ts
247–251 ↗	(On Diff #54931)	this kind of conditional in the test suite can be useful when writing the tests, where maybe we want to see some unexpected errors in the logs and iterate toward better tests -- but is not really doing anything otherwise, should not stay in the final diff
261–265 ↗	(On Diff #54931)	same
274–278 ↗	(On Diff #54931)	same
modules/ecash-lib/src/tx.ts
166 ↗	(On Diff #54931)	can this be referenced somewhere, e.g. is this defined in the node `src/`?