In order to efficiently use the txid subscription from chronik we need to compute this txid. Doing so makes it possible to get the tx added to mempool event from chronik after it is broadcast.
Depends on D18393.
Details
Details
- Reviewers
bytesofman - Group Reviewers
Restricted Project - Commits
- rABC59d8b9fd610e: [ecash-lib] Add txid computation from the Tx object
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- ecash_lib_txid
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Event Timeline
| modules/ecash-lib/src/tx.test.ts | ||
|---|---|---|
| 247–251 | this kind of conditional in the test suite can be useful when writing the tests, where maybe we want to see some unexpected errors in the logs and iterate toward better tests -- but is not really doing anything otherwise, should not stay in the final diff | |
| 261–265 | same | |
| 274–278 | same | |
| modules/ecash-lib/src/tx.ts | ||
| 166 | can this be referenced somewhere, e.g. is this defined in the node src/? | |
| modules/ecash-lib/src/tx.test.ts | ||
|---|---|---|
| 247–251 | that's a debug leftover, good catch | |