Differential D18436

Make the getSpentCoins() utility function public
ClosedPublic
Actions

Authored by Fabien on Jul 31 2025, 08:03.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCacc47e782e41: Make the getSpentCoins() utility function public

Summary

So we can reuse it outside of the validation file. Move it to an appropriate place in the file and use an capitalized name for consistency. There is no change in behavior.

Test Plan

With Chronik:

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 31 2025, 08:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2025, 08:03

Fabien requested review of this revision.Jul 31 2025, 08:03

Harbormaster completed remote builds in B34011: Diff 55052.Jul 31 2025, 08:18

should there be a unittest?

not sure if this is worth testing, I assumed that it has plenty of indirect functional test coverage. And anyway, this diff does not change the existing coverage.

This revision is now accepted and ready to land.Jul 31 2025, 11:15

In D18436#420163, @PiRK wrote:

not sure if this is worth testing, I assumed that it has plenty of indirect functional test coverage. And anyway, this diff does not change the existing coverage.

Yes it doesn't change the existing coverage and we have plenty of functional tests already so I don't think it makes much sense here.

Closed by commit rABCacc47e782e41: Make the getSpentCoins() utility function public (authored by Fabien). · Explain WhyJul 31 2025, 12:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCacc47e782e41: Make the getSpentCoins() utility function public.