Differential D18441

[chronik] Bind the transaction invalidated callback to the ws messages
ClosedPublic
Actions

Authored by Fabien on Jul 31 2025, 20:29.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC500e1cf64b5d: [chronik] Bind the transaction invalidated callback to the ws messages

Summary

Similar to D18432 but for the invalidation event.

Depends on D18438.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 31 2025, 20:29

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2025, 20:29

Fabien requested review of this revision.Jul 31 2025, 20:29

tobias_ruck requested changes to this revision.Jul 31 2025, 20:49

tobias_ruck added a subscriber: tobias_ruck.

tobias_ruck added inline comments.

chronik/chronik-indexer/src/indexer.rs
1028 ↗	(On Diff #55073)	seems a bit hacky, but I get the idea—I suggest we add a "probe_tx" function or so to the Mempool struct (which for now simply calls insert and remove like here), and in the future we can refactor it and fill it with logic that does it without the hack. also makes the code here more readable (we can move a part of the comment out too)
chronik/chronik-lib/src/bridge.rs
301–302 ↗	(On Diff #55073)

This revision now requires changes to proceed.Jul 31 2025, 20:49

Harbormaster completed remote builds in B34024: Diff 55073.Jul 31 2025, 21:02

Use a proxy probe_tx in the mempool and explain why

Undo unecessary explicit typing

Fabien added inline comments.Aug 1 2025, 07:58

chronik/chronik-lib/src/bridge.rs
301–302 ↗	(On Diff #55073)	I blame the autocompletion feature of the IDE on that one

Harbormaster completed remote builds in B34027: Diff 55077.Aug 1 2025, 08:22

Harbormaster completed remote builds in B34028: Diff 55078.Aug 1 2025, 08:41

tobias_ruck accepted this revision.Aug 1 2025, 08:59

tobias_ruck added inline comments.

chronik/chronik-lib/src/bridge.rs
496–499 ↗	(On Diff #55078)	this should work

This revision is now accepted and ready to land.Aug 1 2025, 08:59

Closed by commit rABC500e1cf64b5d: [chronik] Bind the transaction invalidated callback to the ws messages (authored by Fabien). · Explain WhyAug 1 2025, 09:32

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC500e1cf64b5d: [chronik] Bind the transaction invalidated callback to the ws messages.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik_validationinterface.cpp

6 lines

chronik-db/

src/

mem/

20 lines

chronik-http/

src/

1 line

chronik-indexer/

src/

51 lines

2 lines

chronik-lib/

src/

28 lines

5 lines

chronik-proto/

proto/

2 lines

src/

net_processing.cpp

15 lines

test/

functional/

54 lines

Diff 55079

chronik/chronik-cpp/chronik_validationinterface.cpp

Loading...

chronik/chronik-db/src/mem/mempool.rs

Loading...

chronik/chronik-http/src/ws.rs

Loading...

chronik/chronik-indexer/src/indexer.rs

Loading...

chronik/chronik-indexer/src/subs_group.rs

Loading...

chronik/chronik-lib/src/bridge.rs

Loading...

chronik/chronik-lib/src/ffi.rs

Loading...

chronik/chronik-proto/proto/chronik.proto

Loading...

src/net_processing.cpp

Loading...

test/functional/chronik_ws.py

Loading...