Add the spent coins to the tx invalidated validation callback
ClosedPublic
Actions

Authored by Fabien on Jul 31 2025, 14:07.

Details

Reviewers

PiRK
tobias_ruck

Group Reviewers

Restricted Project

Commits

rABC2c8042c1de20: Add the spent coins to the tx invalidated validation callback

Summary

This extends the callback so that chronik can retrieve the token/plugin info without being able to look up its db. This is a similar requirement to the transaction added to mempool callback where chronik needs to process the data before the tx is added to its database (in this case it's been removed already).

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 31 2025, 14:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 31 2025, 14:07

Fabien requested review of this revision.Jul 31 2025, 14:07

Harbormaster completed remote builds in B34014: Diff 55056.Jul 31 2025, 14:13

Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[203/528] Running utility command for check-avalanche-proofcomparator_tests
[204/528] avalanche: testing proofpool_tests
[205/528] Running utility command for check-avalanche-proofpool_tests
[206/528] avalanche: testing proof_tests
[207/528] Running utility command for check-avalanche-proof_tests
[208/528] avalanche: testing stakingrewards_tests
[209/528] Running utility command for check-avalanche-stakingrewards_tests
[210/528] avalanche: testing stakecontendercache_tests
[211/528] Running utility command for check-avalanche-stakecontendercache_tests
[212/528] Linking CXX executable src/pow/test/test-pow
[213/528] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[214/528] pow: testing daa_tests
[215/528] Running utility command for check-pow-daa_tests
[216/528] pow: testing eda_tests
[217/528] Running utility command for check-pow-eda_tests
[218/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[219/528] pow: testing grasberg_tests
[220/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[221/528] Running utility command for check-pow-grasberg_tests
[222/528] Linking CXX executable src/seeder/test/test-seeder
[223/528] seeder: testing db_tests
[224/528] Running utility command for check-seeder-db_tests
[225/528] seeder: testing message_writer_tests
[226/528] Running utility command for check-seeder-message_writer_tests
[227/528] seeder: testing options_tests
[228/528] Running utility command for check-seeder-options_tests
[229/528] seeder: testing p2p_messaging_tests
[230/528] Running utility command for check-seeder-p2p_messaging_tests
[231/528] seeder: testing parse_name_tests
[232/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[233/528] Running utility command for check-seeder-parse_name_tests
[234/528] seeder: testing write_name_tests
[235/528] Running utility command for check-seeder-write_name_tests
[236/528] Running seeder test suite
PASSED: seeder test suite
[237/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[238/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[239/528] avalanche: testing voterecord_tests
[240/528] Running utility command for check-avalanche-voterecord_tests
[241/528] avalanche: testing peermanager_tests
[242/528] Running utility command for check-avalanche-peermanager_tests
[243/528] pow: testing aserti32d_tests
[244/528] Running utility command for check-pow-aserti32d_tests
[245/528] Running pow test suite
PASSED: pow test suite
[246/528] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/util_tests.cpp.o
[247/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[248/528] avalanche: testing processor_tests
[249/528] Running utility command for check-avalanche-processor_tests
[250/528] Running avalanche test suite
PASSED: avalanche test suite
[251/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[252/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[253/528] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[254/528] Linking CXX executable src/qt/test/test_bitcoin-qt
[255/528] bitcoin-qt: testing test_bitcoin-qt
[256/528] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

============================== 20 passed in 0.81s ==============================
[197/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/options_tests.cpp.o
[198/521] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/eda_tests.cpp.o
[199/521] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/aserti32d_tests.cpp.o
[200/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/parse_name_tests.cpp.o
[201/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/write_name_tests.cpp.o
[202/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/message_writer_tests.cpp.o
[203/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/p2p_messaging_tests.cpp.o
[204/521] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/__/wallet/test/wallet_tests.cpp.o
[205/521] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/grasberg_tests.cpp.o
[206/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/bitcoinaddressvalidatortests.cpp.o
[207/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_bitcoin-qt_autogen/mocs_compilation.cpp.o
[208/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/compattests.cpp.o
[209/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/util.cpp.o
[210/521] Test Bitcoin utilities...
[211/521] Building CXX object src/pow/test/CMakeFiles/test-pow.dir/fixture.cpp.o
[212/521] Linking CXX executable src/pow/test/test-pow
[213/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/uritests.cpp.o
[214/521] pow: testing daa_tests
[215/521] pow: testing eda_tests
[216/521] Running utility command for check-pow-daa_tests
[217/521] Running utility command for check-pow-eda_tests
[218/521] pow: testing grasberg_tests
[219/521] Running utility command for check-pow-grasberg_tests
[220/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/guiutiltests.cpp.o
[221/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/optiontests.cpp.o
[222/521] pow: testing aserti32d_tests
[223/521] Running utility command for check-pow-aserti32d_tests
[224/521] Running pow test suite
PASSED: pow test suite
[225/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/apptests.cpp.o
[226/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/rpcnestedtests.cpp.o
[227/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/test_main.cpp.o
[228/521] Building CXX object src/seeder/test/CMakeFiles/test-seeder.dir/fixture.cpp.o
[229/521] Linking CXX executable src/seeder/test/test-seeder
[230/521] seeder: testing db_tests
[231/521] seeder: testing options_tests
[232/521] seeder: testing message_writer_tests
[233/521] seeder: testing p2p_messaging_tests
[234/521] seeder: testing parse_name_tests
[235/521] seeder: testing write_name_tests
[236/521] Running utility command for check-seeder-db_tests
[237/521] Running utility command for check-seeder-options_tests
[238/521] Running utility command for check-seeder-message_writer_tests
[239/521] Running utility command for check-seeder-p2p_messaging_tests
[240/521] Running utility command for check-seeder-parse_name_tests
[241/521] Running utility command for check-seeder-write_name_tests
[242/521] Running seeder test suite
PASSED: seeder test suite
[243/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/__/__/wallet/test/wallet_test_fixture.cpp.o
[244/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/paymentservertests.cpp.o
[245/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/addressbooktests.cpp.o
[246/521] Building CXX object src/qt/test/CMakeFiles/test_bitcoin-qt.dir/wallettests.cpp.o
[247/521] Linking CXX executable src/qt/test/test_bitcoin-qt
[248/521] bitcoin-qt: testing test_bitcoin-qt
[249/521] Running bitcoin-qt test suite
PASSED: bitcoin-qt test suite
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Fabien planned changes to this revision.Jul 31 2025, 14:23

Fix variable shadowing

Harbormaster completed remote builds in B34015: Diff 55057.Jul 31 2025, 14:40

Rebase

Fabien added a child revision: D18441: [chronik] Bind the transaction invalidated callback to the ws messages.Jul 31 2025, 20:29

PiRK accepted this revision.Jul 31 2025, 20:38

This revision is now accepted and ready to land.Jul 31 2025, 20:38

Harbormaster completed remote builds in B34023: Diff 55072.Jul 31 2025, 20:49

tobias_ruck accepted this revision.Jul 31 2025, 20:49

Closed by commit rABC2c8042c1de20: Add the spent coins to the tx invalidated validation callback (authored by Fabien). · Explain WhyAug 1 2025, 07:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC2c8042c1de20: Add the spent coins to the tx invalidated validation callback.