Differential D1845

Use uint8_t instead of unsigned char
ClosedPublic
Actions

Authored by deadalnix on Sep 30 2018, 15:53.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING0c226d0dea39: Use uint8_t instead of unsigned char
rABC0c226d0dea39: Use uint8_t instead of unsigned char

Summary

As per title.

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

uint8t

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3452
Build 4980: Bitcoin ABC Buildbot (legacy)
Build 4979: arc lint + arc unit

Event Timeline

deadalnix created this revision.Sep 30 2018, 15:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 30 2018, 15:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3452: Diff 5186.Sep 30 2018, 16:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added a child revision: D1846: Specialized double-SHA256 with 64 byte inputs with SSE4.1 and AVX2.Sep 30 2018, 16:20

jasonbcox accepted this revision.Sep 30 2018, 16:39

This revision is now accepted and ready to land.Sep 30 2018, 16:39

Closed by commit rABC0c226d0dea39: Use uint8_t instead of unsigned char (authored by deadalnix). · Explain WhySep 30 2018, 16:42

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

crypto/

sha256.cpp

10 lines

sha256_sse4.cpp

2 lines

netaddress.cpp

3 lines

Diff 5186

View Options

src/crypto/sha256.cpp

View Options

src/crypto/sha256_sse4.cpp

View Options

Use uint8_t instead of unsigned charClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5186

src/crypto/sha256.cpp

src/crypto/sha256_sse4.cpp

src/netaddress.cpp

Use uint8_t instead of unsigned char
ClosedPublic
Actions

Revision Contents
Changeset List