Follow implementation of scanapp.org, support zoom, improve modal style. Seems to improve scanning behavior.
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC316ea48bb7b7: [Cashtab] Replace zxing with html5-qrscode
This is deployed at cashtab.io. Try scanning QR codes. npm test
This QR code in particular:
- cashtab.com struggles to scan it
- cashtab.io (should) scan it instantly
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
[13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 52% (11/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 57% (12/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 61% (13/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 66% (14/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 71% (15/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 76% (16/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 80% (17/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 85% (18/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 90% (19/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 95% (20/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21), done. [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 9% (1/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 18% (2/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 27% (3/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 36% (4/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 45% (5/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 54% (6/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 63% (7/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 72% (8/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 81% (9/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 90% (10/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11), done. [13:40:50]i: VCS root 'Bitcoin ABC Staging': remote: Total 11 (delta 8), reused 0 (delta 0), pack-reused 0 [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 9% (1/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 18% (2/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 27% (3/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 36% (4/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 45% (5/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 54% (6/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 63% (7/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 72% (8/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 81% (9/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 90% (10/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11), 3.81 KiB | 3.81 MiB/s, done. [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 0% (0/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 12% (1/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 25% (2/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 37% (3/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 50% (4/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 62% (5/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 75% (6/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 87% (7/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8) [13:40:50]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8), completed with 8 local objects. [13:40:51]i: VCS root 'Bitcoin ABC Staging': From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging [13:40:51]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/base/55228 -> phabricator/base/55228 [13:40:51]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/diff/55228 -> phabricator/diff/55228 [13:40:52]i: Done collecting changes for 'Bitcoin ABC Staging': 1 changes collected 1 changes persisted, total time: 5s,684ms, persisting time: 5ms [13:40:52] : Compute revision for 'Bitcoin ABC Staging' [13:40:52] : [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 59f3b13fa43de9f9ab98e640859132bb6819b66b [13:40:52]i: [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 84051 [13:40:52] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout [13:40:52] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e [13:40:52]i: [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 83296 [13:40:52] : [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 59f3b13fa43de9f9ab98e640859132bb6819b66b [13:40:52] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e [13:40:56]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Tail of the build log:
[13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 52% (11/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 57% (12/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 61% (13/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 66% (14/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 71% (15/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 76% (16/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 80% (17/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 85% (18/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 90% (19/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 95% (20/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Counting objects: 100% (21/21), done. [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 9% (1/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 18% (2/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 27% (3/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 36% (4/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 45% (5/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 54% (6/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 63% (7/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 72% (8/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 81% (9/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 90% (10/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Compressing objects: 100% (11/11), done. [13:41:54]i: VCS root 'Bitcoin ABC Staging': remote: Total 11 (delta 8), reused 0 (delta 0), pack-reused 0 [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 9% (1/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 18% (2/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 27% (3/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 36% (4/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 45% (5/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 54% (6/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 63% (7/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 72% (8/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 81% (9/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 90% (10/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Receiving objects: 100% (11/11), 3.86 KiB | 3.86 MiB/s, done. [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 0% (0/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 12% (1/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 25% (2/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 37% (3/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 50% (4/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 62% (5/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 75% (6/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 87% (7/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8) [13:41:54]i: VCS root 'Bitcoin ABC Staging': Resolving deltas: 100% (8/8), completed with 8 local objects. [13:41:54]i: VCS root 'Bitcoin ABC Staging': From ssh://reviews.bitcoinabc.org:2221/source/bitcoin-abc-staging [13:41:54]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/base/55229 -> phabricator/base/55229 [13:41:54]i: VCS root 'Bitcoin ABC Staging': * [new tag] phabricator/diff/55229 -> phabricator/diff/55229 [13:41:55]i: Done collecting changes for 'Bitcoin ABC Staging': 1 changes collected 1 changes persisted, total time: 5s,726ms, persisting time: 5ms [13:41:55] : Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout [13:41:55] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Upper limit revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e [13:41:55]i: [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] MaxModId = 83296 [13:41:55] : Compute revision for 'Bitcoin ABC Staging' [13:41:55] : [Compute revision for 'Bitcoin ABC Staging'] Upper limit revision: 524e9b5b20abe8631a0b21bc5efb8993622aa245 [13:41:55]i: [Compute revision for 'Bitcoin ABC Staging'] MaxModId = 84052 [13:41:55] : [Compute revision for 'abc-infrastructure' in Automated Deployments / Bitcoin ABC Infra / Bitcoin-ABC Infra Checkout] Computed revision: 602c7e2af027bb16cc6a4fc5a25601e8c853be5e [13:41:55] : [Compute revision for 'Bitcoin ABC Staging'] Computed revision: 524e9b5b20abe8631a0b21bc5efb8993622aa245 [13:42:00]W: Build was removed from the queue with comment: This build has not been started because some of the builds it depends on failed to start
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.91.14.25:41538 for the next 60 minutes.