Differential D18513

[avalanche] Clarify locking expectation in GetAvalancheVoteForTx
ClosedPublic
Actions

Authored by Fabien on Aug 21 2025, 09:38.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCcd560527eb8e: [avalanche] Clarify locking expectation in GetAvalancheVoteForTx

Summary

Also release the cs_main lock when calling isPolled to avoid a lock order inversion between the RWLock for voteRecords and cs_main.

Test Plan

Run the abc_p2p_avalanche_transaction_finalization.py test with TSAN

Diff Detail

Repository

rABC Bitcoin ABC

Branch

avalanche_fix_txvote_deadlock

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34198
Build 67864: Build Diff	build-debug · build-without-wallet · lint-circular-dependencies · build-clang · build-clang-tidy · build-diff
Build 67863: arc lint + arc unit

Event Timeline

Fabien created this revision.Aug 21 2025, 09:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 21 2025, 09:38

Fabien requested review of this revision.Aug 21 2025, 09:38

Harbormaster completed remote builds in B34198: Diff 55313.Aug 21 2025, 10:04

PiRK accepted this revision.Aug 21 2025, 15:10

This revision is now accepted and ready to land.Aug 21 2025, 15:10

Closed by commit rABCcd560527eb8e: [avalanche] Clarify locking expectation in GetAvalancheVoteForTx (authored by Fabien). · Explain WhyAug 21 2025, 21:22

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCcd560527eb8e: [avalanche] Clarify locking expectation in GetAvalancheVoteForTx.

Revision Contents
Changeset List

Path

Size

src/

net_processing.cpp

77 lines

Diff 55313

View Options

[avalanche] Clarify locking expectation in GetAvalancheVoteForTxClosedPublicActions