Page MenuHomePhabricator

[avalanche] Fix abc_p2p_avalanche_transaction_voting flakiness
ClosedPublic

Authored by Fabien on Aug 26 2025, 13:38.

Details

Summary

There is a couple issues in this test:

  • The initial poll_node is not disconnected and not part of the quorum, which means this is an avalanche peer that will never respond to polls. This does not cause any failure but slows the test a bit and create false positive errors in the log.
  • The stalling vote does not consume all the polls, and there can be a lot of them because stalling requires a lot of voting rounds. This can eventually cause the node to stop polling because too many polls are already in flight.
Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_transaction_voting --repeat 100

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_abc_p2p_avalanche_transaction_voting_flakiness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34232
Build 67932: Build Diffbuild-diff · build-debug · build-clang · build-clang-tidy · build-without-wallet
Build 67931: arc lint + arc unit