Fix numerous declaratiosn shadowing others
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2018, 15:43.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING568780144818: Fix numerous declaratiosn shadowing others
rABC568780144818: Fix numerous declaratiosn shadowing others

Summary

Eventually we'll get to a point where we can enable -Wshadow by default.

Test Plan

Add -Wshadow as a compler flag

make

Ensure numerous warnings are gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fixmanyshadow

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3485
Build 5046: Bitcoin ABC Buildbot (legacy)
Build 5045: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2018, 15:43

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2018, 15:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fix more in the Qt codebase

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3484: Diff 5230.Oct 2 2018, 16:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3485: Diff 5231.Oct 2 2018, 16:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Oct 3 2018, 01:36

This revision is now accepted and ready to land.Oct 3 2018, 01:36

Closed by commit rABC568780144818: Fix numerous declaratiosn shadowing others (authored by deadalnix). · Explain WhyOct 3 2018, 11:36

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoinaddressvalidator.h

2 lines

bitcoinaddressvalidator.cpp

4 lines

2 lines

13 lines

4 lines

10 lines

4 lines

receivecoinsdialog.cpp

12 lines

receiverequestdialog.h

2 lines

receiverequestdialog.cpp

4 lines

test/

uritests.cpp

4 lines

walletframe.h

6 lines

walletframe.cpp

8 lines

seeder/

bitcoin.cpp

16 lines

dns.cpp

18 lines

test/

miner_tests.cpp

14 lines

script_tests.cpp

16 lines

txvalidationcache_tests.cpp

4 lines

wallet/

wallet.cpp

27 lines

Diff 5231

View Options

src/qt/bitcoinaddressvalidator.h

View Options

src/qt/bitcoinaddressvalidator.cpp

View Options

src/qt/bitcoingui.h

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/openuridialog.h

View Options

src/qt/openuridialog.cpp

View Options

src/qt/receivecoinsdialog.h

View Options

src/qt/receivecoinsdialog.cpp

View Options

src/qt/receiverequestdialog.h

View Options

src/qt/receiverequestdialog.cpp

View Options

src/qt/test/uritests.cpp

View Options

src/qt/walletframe.h

View Options

src/qt/walletframe.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/seeder/dns.cpp

View Options

src/test/miner_tests.cpp

View Options

src/test/script_tests.cpp

View Options

src/test/txvalidationcache_tests.cpp

View Options

Fix numerous declaratiosn shadowing othersClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 5231

src/qt/bitcoinaddressvalidator.h

src/qt/bitcoinaddressvalidator.cpp

src/qt/bitcoingui.h

src/qt/bitcoingui.cpp

src/qt/openuridialog.h

src/qt/openuridialog.cpp

src/qt/receivecoinsdialog.h

src/qt/receivecoinsdialog.cpp

src/qt/receiverequestdialog.h

src/qt/receiverequestdialog.cpp

src/qt/test/uritests.cpp

src/qt/walletframe.h

src/qt/walletframe.cpp

src/seeder/bitcoin.cpp

src/seeder/dns.cpp

src/test/miner_tests.cpp

src/test/script_tests.cpp

src/test/txvalidationcache_tests.cpp

src/wallet/wallet.cpp

Fix numerous declaratiosn shadowing others
ClosedPublic
Actions

Revision Contents
Changeset List