[rust] Bump Rust version to 1.90
Changes PlannedPublic
Actions

Authored by tobias_ruck on Sep 26 2025, 10:18.

Details

Reviewers

Fabien
PiRK

Group Reviewers

Restricted Project

Summary

No strong reason to do this, but better stay up to date.

Also update all dependencies, as some previously caused clippy to complain.

Test Plan

entire CI pipeline

Diff Detail

Repository

rABC Bitcoin ABC

Branch

bump-rust-version-1.90

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34600
Build 68666: Build Diff	build-chronik-plugins · ecash-lib-integration-tests · chronik-client-integration-tests · build-chronik · ecash-agora-integration-tests
Build 68665: arc lint + arc unit

Event Timeline

tobias_ruck created this revision.Sep 26 2025, 10:18

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 26 2025, 10:18

Harbormaster completed remote builds in B34600: Diff 55891.Sep 26 2025, 10:41

Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

   Doc-tests chronik_bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s

   Doc-tests chronik_indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

   Doc-tests chronik_bridge

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_db

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_http

running 1 test
test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.21s

   Doc-tests chronik_indexer

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_common

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_plugin_impl

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_proto

running 0 tests

test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

   Doc-tests chronik_util

running 2 tests
test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored
test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored

test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s

ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1

Also update Cargo.lock (via cargo update), to make clippy happy

Harbormaster completed remote builds in B34601: Diff 55892.Sep 26 2025, 12:36

tobias_ruck edited the summary of this revision. (Show Details)Sep 26 2025, 17:28

tobias_ruck published this revision for review.Sep 26 2025, 17:31

looks reasonable to me

PiRK accepted this revision.Sep 29 2025, 12:24

This revision is now accepted and ready to land.Sep 29 2025, 12:24

@bot guix-linux guix-osx guix-win

teamcity awarded a token.Sep 29 2025, 12:58

Build Bitcoin ABC Diffs / Diff Testing (guix-win) failed.

Tail of the build log:

note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
    Finished `release` profile [optimized] target(s) in 0.14s
[2/18] Building native src/secp256k1/gen_context
ninja: no work to do.
[4/18] Generating ../cargo/build/x86_64-pc-windows-gnu/cxxbridge/chronik-bridge/src/ffi.rs.cc, ../cargo/build/x86_64-pc-windows-gnu/cxxbridge/chronik_lib/src/ffi.rs.cc
Generating cxx bridge files
[6/11] Running security-check.py on iguana...
[7/11] Running security-check.py on bitcoin-cli...
[8/11] Running security-check.py on bitcoin-tx...
[9/11] Running security-check.py on bitcoin-wallet...
[10/11] Running security-check.py on bitcoind...
[11/11] Running security-check.py on bitcoin-qt...
[0/18] Preparing native build...
-- Looking for __builtin_clz
-- Looking for __builtin_clz - found
-- Looking for __builtin_clzl
-- Looking for __builtin_clzl - found
-- Looking for __builtin_clzll
-- Looking for __builtin_clzll - found
-- Looking for __builtin_ctz
-- Looking for __builtin_ctz - found
-- Looking for __builtin_ctzl
-- Looking for __builtin_ctzl - found
-- Looking for __builtin_ctzll
-- Looking for __builtin_ctzll - found
-- Looking for __builtin_popcount
-- Looking for __builtin_popcount - found
-- Looking for __builtin_saddll_overflow
-- Looking for __builtin_saddll_overflow - found
-- Looking for __builtin_ssubll_overflow
-- Looking for __builtin_ssubll_overflow - found
-- Configuring done
-- Generating done
-- Build files have been written to: /bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/native
[1/18] cd /bitcoin/chronik/chronik-lib && /gnu/store/w6xrmrn9ndl0v22vmi8wivrjh6h6mqmc-cmake-minimal-3.24.2/bin/cmake -E env CC_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-gcc CXX_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-g++ AR_x86_64_pc_windows_gnu=/home/bitcoinabc/.guix-profile/bin/x86_64-w64-mingw32-ar CORROSION_BUILD_DIR=/bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/chronik CARGO_BUILD_RUSTC=/home/bitcoinabc/.rustup/toolchains/1.90.0-x86_64-unknown-linux-gnu/bin/rustc /home/bitcoinabc/.rustup/toolchains/1.90.0-x86_64-unknown-linux-gnu/bin/cargo rustc --lib --target=x86_64-pc-windows-gnu --package chronik_lib --manifest-path /bitcoin/chronik/chronik-lib/Cargo.toml --target-dir /bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/./cargo/build --release --locked -- -Cdefault-linker-libraries=yes -Clink-args=--target=x86_64-w64-mingw32
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /bitcoin/modules/avalanche-lib-wasm/Cargo.toml
workspace: /bitcoin/Cargo.toml
warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"`
note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest
note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest
note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions
    Finished `release` profile [optimized] target(s) in 0.13s
[2/18] Building native src/secp256k1/gen_context
ninja: no work to do.
[3/18] Running utility command for _cargo-build_chronik_lib
[5/10] Running symbol-check.py on bitcoin-cli...
[6/10] Running symbol-check.py on iguana...
[7/10] Running symbol-check.py on bitcoin-tx...
[8/10] Running symbol-check.py on bitcoin-wallet...
[9/10] Running symbol-check.py on bitcoind...
FAILED: src/CMakeFiles/symbol-check-bitcoind /bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/src/CMakeFiles/symbol-check-bitcoind 
cd /bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/src && /home/bitcoinabc/.guix-profile/bin/python3.10 /bitcoin/contrib/devtools/symbol-check.py /bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/src/bitcoind.exe
combase.dll is not in ALLOWED_LIBRARIES!
/bitcoin/distsrc-1980d7e5b7ab-x86_64-w64-mingw32/src/bitcoind.exe: failed DYNAMIC_LIBRARIES
[10/10] Running symbol-check.py on bitcoin-qt...
ninja: build stopped: subcommand failed.
Build guix-win failed with exit code 1

needs combase.dll