Page MenuHomePhabricator
Differential D1875

net: Minor accumulated cleanups
ClosedPublic
Actions

Authored by deadalnix on Oct 3 2018, 19:23.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd5a67708e127: net: Minor accumulated cleanups
rABCd5a67708e127: net: Minor accumulated cleanups
Summary

This is a backport of core PR12855

Depends on D1874

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
netnits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3503
Build 5082: Bitcoin ABC Buildbot (legacy)
Build 5081: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 3 2018, 19:23
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 3 2018, 19:23
teamcity added a subscriber: teamcity.Oct 3 2018, 19:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 3 2018, 19:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3503: Diff 5257.Oct 3 2018, 19:40
jasonbcox requested changes to this revision.Oct 3 2018, 20:13
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/compat.h
92

sockopt_arg_type should be used in SetSocketNoDelay as well.

This revision now requires changes to proceed.Oct 3 2018, 20:13
deadalnix updated this revision to Diff 5264.Oct 4 2018, 09:55

Use sockopt_arg_type more thoroughly

teamcity added a comment.Oct 4 2018, 09:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 4 2018, 10:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3505: Diff 5264.Oct 4 2018, 10:12
jasonbcox accepted this revision.Oct 4 2018, 19:02
This revision is now accepted and ready to land.Oct 4 2018, 19:02
Closed by commit rABCd5a67708e127: net: Minor accumulated cleanups (authored by Thomas Snider <tjps636@gmail.com>, committed by deadalnix). · Explain WhyOct 5 2018, 09:31
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
5 lines
8 lines
36 lines
16 lines
41 lines
11 lines

Diff 5257

View Options

src/bitcoind.cpp

Loading...
View Options

src/compat.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/netbase.cpp

Loading...