Differential D18780

[electrum] make config parameter non-optional for instantiating a network
ClosedPublic
Actions

Authored by PiRK on Oct 10 2025, 10:03.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1fcc8830b426: [electrum] make config parameter non-optional for instantiating a network

Summary

This "feature" was only used in a script, so just instantiate configuration there and pass it to the network.

Depends on D18779

Test Plan

python scripts/get_history.py ecash:qqlz0neyh0z8epd9zu6rmjankgvpnksltqljeg4apc

Run the application, check for no python errors on startup

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Oct 10 2025, 10:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2025, 10:03

PiRK requested review of this revision.Oct 10 2025, 10:03

PiRK edited the summary of this revision. (Show Details)Oct 10 2025, 10:04

PiRK added a parent revision: D18779: [electrum] pass a config to alias.resolve.

PiRK added a child revision: D18781: [electrum] deglobalize config.Oct 10 2025, 10:09

Harbormaster completed remote builds in B34750: Diff 56128.Oct 10 2025, 10:12

Fabien accepted this revision.Oct 13 2025, 07:17

This revision is now accepted and ready to land.Oct 13 2025, 07:17

Closed by commit rABC1fcc8830b426: [electrum] make config parameter non-optional for instantiating a network (authored by PiRK). · Explain WhyOct 13 2025, 09:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1fcc8830b426: [electrum] make config parameter non-optional for instantiating a network.

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc/

network.py

4 lines

scripts/

get_history.py

4 lines

Diff 56142

View Options

electrum/electrumabc/network.py