Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5eb88b202488: [ecash-agora] take method only supports taking by the taking wallet

Summary

Depends on D18846

Oversight in copypasta params. When we call take() with a wallet, we do not want to support taking to some other address that is not the wallet address.

Some niche use cases may want to do this, they can use the existing acceptTx method.

Test Plan

npm test, CI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Tue, Oct 28, 16:28

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Oct 28, 16:28

bytesofman mentioned this in D18837: [ecash-wallet] Properly construct postage tx to support serialization and server deser.Tue, Oct 28, 16:29

Harbormaster completed remote builds in B34891: Diff 56337.Tue, Oct 28, 16:35

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Failed tests logs:

====== AgoraPartial SLP: AgoraPartial SLP 1000 for 1sat/token, dust accept, must allowUnspendable.AgoraPartial SLP AgoraPartial SLP 1000 for 1sat/token, dust accept, must allowUnspendable ======
Error: Insufficient input sats (2333): Can only pay for 695 fees, but 1186 required
    at TxBuilder.sign (/work/modules/ecash-lib/src/txBuilder.ts:204:23)
    at AgoraOffer.take (src/agora.ts:293:34)
    at takeSlpOffer (tests/partial-helper-slp.ts:143:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Context.<anonymous> (tests/partial.slp.test.ts:500:32)

Each failure log is accessible here:
AgoraPartial SLP: AgoraPartial SLP 1000 for 1sat/token, dust accept, must allowUnspendable.AgoraPartial SLP AgoraPartial SLP 1000 for 1sat/token, dust accept, must allowUnspendable

CI test

Harbormaster completed remote builds in B34892: Diff 56338.Tue, Oct 28, 16:53

add separate routine to fund taker

Harbormaster completed remote builds in B34893: Diff 56339.Tue, Oct 28, 19:55

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Failed tests logs:

====== AgoraPartial SLP: AgoraPartial SLP 1000 for 1000sat/token, 1 accept.AgoraPartial SLP AgoraPartial SLP 1000 for 1000sat/token, 1 accept ======
Error: Insufficient input sats (3200): Can only pay for 1107 fees, but 1179 required
    at TxBuilder.sign (/work/modules/ecash-lib/src/txBuilder.ts:204:23)
    at AgoraOffer.take (src/agora.ts:293:34)
    at takeSlpOffer (tests/partial-helper-slp.ts:143:48)
    at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
    at async Context.<anonymous> (tests/partial.slp.test.ts:502:32)

Each failure log is accessible here:
AgoraPartial SLP: AgoraPartial SLP 1000 for 1000sat/token, 1 accept.AgoraPartial SLP AgoraPartial SLP 1000 for 1000sat/token, 1 accept