Page MenuHomePhabricator
Differential D18851

test: add vectors for the SIGHASH single bug
ClosedPublic
Actions

Authored by PiRK on Thu, Oct 30, 12:26.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCae02ef358df4: test: add vectors for the SIGHASH single bug
Summary

We take a mainnet transaction knwon to trigger the sighash_single bug (txid: 99fc1e5c753459808bac56435b3d45f2fcf0dd73016ea14460d63e9ddf353714), and we pass it to SignatureHash function with two different sighash types:

  • SINGLE (pre-UAHF tx): in this case the signature hash is 1 for any flag combination
  • SINGLE | FORKID (0x03 | 0x40 = 0x43 = 67): in this case the signature hash is 1 only if the SCRIPT_ENABLE_SIGHASH_FORKID flag is not set

This is done for input index 2, for a transaction that has only one output, thus triggering the nOut out of range issue.

Test Plan

ninja check

Diff Detail

Event Timeline

PiRK created this revision.Thu, Oct 30, 12:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 30, 12:26
PiRK requested review of this revision.Thu, Oct 30, 12:26
PiRK mentioned this in D18848: script: (refactor) prepare for introducing sighash midstate cache.
PiRK edited the summary of this revision. (Show Details)Thu, Oct 30, 12:29
PiRK added inline comments.
src/test/data/sighash.json
1003–1004
["raw_transaction, script, input_index, hashType, signature_hash (regular), signature_hash(no forkid), signature_hash(replay protected)"],
Harbormaster completed remote builds in B34910: Diff 56361.Thu, Oct 30, 12:41
PiRK mentioned this in D18849: script: (optimization) introduce sighash midstate caching.Thu, Oct 30, 15:34
Fabien accepted this revision.Thu, Oct 30, 20:51
This revision is now accepted and ready to land.Thu, Oct 30, 20:51
Closed by commit rABCae02ef358df4: test: add vectors for the SIGHASH single bug (authored by PiRK). · Explain WhyFri, Oct 31, 09:57
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCae02ef358df4: test: add vectors for the SIGHASH single bug.

Revision Contents
Changeset List

PathSize
src/
test/
data/
4 lines

Diff 56361

View Options

src/test/data/sighash.json

Loading...