[seeder] avoid creating copy in loop variable
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 3, 19:44.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCc391821a705e: [seeder] avoid creating copy in loop variable

Summary

Use references to avoid copies. This causes warnings / errors with c++20.

And while we are touching this, upgrade code to structured bindings.

Depends on D18663

Test Plan

ninja check-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Nov 3, 19:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 3, 19:44

PiRK requested review of this revision.Mon, Nov 3, 19:44

PiRK added a child revision: D18862: [cpp] move to c++20.Mon, Nov 3, 19:46

Harbormaster completed remote builds in B34940: Diff 56404.Mon, Nov 3, 19:57

Macro likestamp:

This revision is now accepted and ready to land.Tue, Nov 4, 08:37

Closed by commit rABCc391821a705e: [seeder] avoid creating copy in loop variable (authored by PiRK). · Explain WhyTue, Nov 4, 09:40

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCc391821a705e: [seeder] avoid creating copy in loop variable.

Revision Contents
Changeset List

Path

Size

src/

seeder/

test/

options_tests.cpp

41 lines

Diff 56406

View Options

src/seeder/test/options_tests.cpp

[seeder] avoid creating copy in loop variableClosedPublicActions