Page MenuHomePhabricator
Differential D18882

[metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume
ClosedPublic
Actions

Authored by bytesofman on Wed, Nov 5, 17:55.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCe8c6af084008: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume
Summary

The current approach is not actually cumulative, as it shows decreasing cumulative volume with decreasing price.

Calculate the USD value every day so we can properly calculate the cumulative value.

Test Plan

npm test, CI, check screenshots.

current prod (does not make sense, cumulative volume cannot decrease):

image.png (705×1 px, 93 KB)

after this diff:

image.png (588×1 px, 197 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bytesofman created this revision.Wed, Nov 5, 17:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 17:55
Harbormaster completed remote builds in B34971: Diff 56446.Wed, Nov 5, 17:58
bytesofman added a child revision: D18883: [metachronik] Add support for reindexing from a given date.Wed, Nov 5, 18:31
bytesofman updated this revision to Diff 56454.Wed, Nov 5, 19:18

back out unrelated changes

bytesofman edited the test plan for this revision. (Show Details)Wed, Nov 5, 19:19
Harbormaster completed remote builds in B34979: Diff 56454.Wed, Nov 5, 19:20
bytesofman updated this revision to Diff 56455.Wed, Nov 5, 19:20

drop unused migration script

Harbormaster completed remote builds in B34980: Diff 56455.Wed, Nov 5, 19:22
bytesofman updated this revision to Diff 56458.Wed, Nov 5, 19:32

make the schema consistent for xec and usd values

bytesofman published this revision for review.Wed, Nov 5, 19:37
Harbormaster completed remote builds in B34983: Diff 56458.Wed, Nov 5, 19:51
Fabien accepted this revision.Wed, Nov 5, 22:04
This revision is now accepted and ready to land.Wed, Nov 5, 22:04
Closed by commit rABCe8c6af084008: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume (authored by bytesofman). · Explain WhyWed, Nov 5, 22:10
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCe8c6af084008: [metachronik, charts.e.cash] Correctly calculate cumulative agora usd volume.

Revision Contents
Changeset List

PathSize
apps/
metachronik/
src/
database/
19 lines
web/
charts.e.cash/
src/
lib/
62 lines

Diff 56472

View Options

apps/metachronik/src/database/schema.sql

Loading...
View Options

web/charts.e.cash/src/lib/database.ts

Loading...