Page MenuHomePhabricator

Added txtools utility functions
ClosedPublic

Authored by jasonbcox on Oct 5 2018, 20:08.

Details

Summary

Part 1 of many for incorporating changes from https://github.com/bitcoinxt/bitcoinxt/pull/487
The goal is to improve the test suite so that it doesn't fail post-fork.
Starts work on T418

This diff differs from the original primarily in variable/function naming and other minor cleanups.

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Oct 5 2018, 20:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 5 2018, 20:08
jasonbcox edited the summary of this revision. (Show Details)Oct 5 2018, 20:09
deadalnix requested changes to this revision.Oct 6 2018, 09:22
deadalnix added inline comments.
test/functional/test_framework/txtools.py
26 ↗(On Diff #5296)

There was a bug with that in some test. getrandbit can starts with too many zeros once in a while and you'll get something smaller than you expect. Digging into the HF activation test history should give you all the details.

This revision now requires changes to proceed.Oct 6 2018, 09:22
jasonbcox updated this revision to Diff 5312.Oct 8 2018, 18:27

Fixed randbits usage

deadalnix accepted this revision.Oct 8 2018, 21:12
deadalnix added inline comments.
test/functional/test_framework/blocktools.py
66 ↗(On Diff #5312)

I think we should keep the old school style padding here. It's how it's done by miners in practice.

This revision is now accepted and ready to land.Oct 8 2018, 21:12
This revision was automatically updated to reflect the committed changes.
jasonbcox edited the summary of this revision. (Show Details)Oct 12 2018, 22:03