Paths

Table of Contentst

Differential D18948

Use DataStream where possible
ClosedPublic
Actions

Authored by PiRK on Mon, Nov 17, 15:08.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABCe63a388c3f04: Use DataStream where possible

Summary

This replaces CDataStream with DataStream everywhere where it doesn't cause a compilation failure (i.e no downstream code is calling ss.Get/SetVersion or ss.Get/SetType).

This concludes backport of core#25296
https://github.com/bitcoin/bitcoin/pull/25296/commits/fa29e73cdab82f98682821322cda89b1084ba887
https://github.com/bitcoin/bitcoin/pull/25296/commits/fa035fe2d61d0c98d1bfd0153a0c3b5eb9d40de4
Depends on D18947

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Mon, Nov 17, 15:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 17, 15:08

PiRK requested review of this revision.Mon, Nov 17, 15:08

teamcity edited the summary of this revision. (Show Details)Mon, Nov 17, 15:08

PiRK added inline comments.Mon, Nov 17, 15:14

src/streams.h
420 ↗	(On Diff #56636)	this change is the second commit
src/wallet/bdb.cpp
762 ↗	(On Diff #56636)	This and the next line are the only non-trivial changes in the diff. The fact that we can change the type of `ssKey` to DataStream demonstrates that nothing calls `GetType` or tries to access the `nType` member (which is private anyway) on that returned object.

Harbormaster completed remote builds in B35086: Diff 56636.Mon, Nov 17, 15:35

Fabien accepted this revision.Tue, Nov 18, 10:52

This revision is now accepted and ready to land.Tue, Nov 18, 10:52

Closed by commit rABCe63a388c3f04: Use DataStream where possible (authored by PiRK). · Explain WhyTue, Nov 18, 11:22

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCe63a388c3f04: Use DataStream where possible.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-cpp/

chronik_bridge.cpp

10 lines

test/

bridgeprimitives_tests.cpp

4 lines

chronikbridge_tests.cpp

10 lines

src/

avalanche/

2 lines

4 lines

test/

compactproofs_tests.cpp

24 lines

bench/

6 lines

load_external.cpp

2 lines

2 lines

rpc_blockchain.cpp

3 lines

blockencodings.cpp

2 lines

common/

4 lines

6 lines

2 lines

20 lines

iguana/

2 lines

kernel/

2 lines

4 lines

qt/

recentrequeststablemodel.cpp

4 lines

walletmodel.cpp

2 lines

20 lines

rpc/

4 lines

2 lines

5 lines

1 line

test/

blockencodings_tests.cpp

32 lines

blockfilter_tests.cpp

2 lines

bloom_tests.cpp

764 lines

checkpoints_tests.cpp

68 lines

coins_tests.cpp

18 lines

crypto_tests.cpp

54 lines

fuzz/

4 lines

6 lines

2 lines

4 lines

4 lines

4 lines

2 lines

prevector_tests.cpp

4 lines

script_tests.cpp

14 lines

serialize_intcode_tests.cpp

6 lines

serialize_tests.cpp

24 lines

sigcache_tests.cpp

8 lines

sighash_tests.cpp

4 lines

sighashtype_tests.cpp

2 lines

streams_tests.cpp

16 lines

transaction_tests.cpp

12 lines

txpackage_tests.cpp

66 lines

uint256_tests.cpp

2 lines

util/

setup_common.cpp

190 lines

wallet/

10 lines

16 lines

30 lines

rpc/

3 lines

10 lines

10 lines

test/

psbt_wallet_tests.cpp

31 lines

Diff 56644

chronik/chronik-cpp/chronik_bridge.cpp

Loading...

chronik/test/bridgeprimitives_tests.cpp

Loading...

chronik/test/chronikbridge_tests.cpp

Loading...

src/avalanche/delegation.cpp

Loading...

src/avalanche/proof.cpp

Loading...

src/avalanche/test/compactproofs_tests.cpp

Loading...

src/bench/checkblock.cpp

Loading...

src/bench/load_external.cpp

Loading...

src/bench/prevector.cpp

Loading...

src/bench/rpc_blockchain.cpp

Loading...

src/blockencodings.cpp

Loading...

src/common/bloom.cpp

Loading...

src/core_read.cpp

Loading...

src/core_write.cpp

Loading...

src/dbwrapper.h

Loading...

src/iguana/iguana.cpp

Loading...

src/kernel/coinstats.h

Loading...

src/kernel/coinstats.cpp

Loading...

src/qt/recentrequeststablemodel.cpp

Loading...

src/qt/walletmodel.cpp

Loading...

src/rest.cpp

Loading...

src/rpc/avalanche.cpp

Loading...

src/rpc/blockchain.cpp

Loading...

src/rpc/txoutproof.cpp

Loading...

src/streams.h

Loading...

src/test/blockencodings_tests.cpp

Loading...

src/test/blockfilter_tests.cpp

Loading...

src/test/bloom_tests.cpp

Loading...

src/test/checkpoints_tests.cpp

Loading...

src/test/coins_tests.cpp

Loading...

src/test/crypto_tests.cpp

Loading...

src/test/fuzz/float.cpp

Loading...

src/test/fuzz/integer.cpp

Loading...

src/test/fuzz/key.cpp

Loading...

src/test/fuzz/prevector.cpp

Loading...

src/test/fuzz/string.cpp

Loading...

src/test/key_tests.cpp

Loading...

src/test/pmt_tests.cpp

Loading...

src/test/prevector_tests.cpp

Loading...

src/test/script_tests.cpp

Loading...

src/test/serialize_intcode_tests.cpp

Loading...

src/test/serialize_tests.cpp

Loading...

src/test/sigcache_tests.cpp

Loading...

src/test/sighash_tests.cpp

Loading...

src/test/sighashtype_tests.cpp

Loading...

src/test/streams_tests.cpp

Loading...

src/test/transaction_tests.cpp

Loading...

src/test/txpackage_tests.cpp

Loading...

src/test/uint256_tests.cpp

Loading...

src/test/util/setup_common.cpp

Loading...

src/wallet/bdb.h

Loading...

src/wallet/bdb.cpp

Loading...

src/wallet/db.h

Loading...

src/wallet/rpc/backup.cpp

Loading...

src/wallet/sqlite.h

Loading...

src/wallet/sqlite.cpp

Loading...

src/wallet/test/psbt_wallet_tests.cpp

Loading...