Page MenuHomePhabricator
Differential D18977

log: Nuke error(...)
ClosedPublic
Actions

Authored by PiRK on Fri, Nov 21, 11:09.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3a3d9942a46d: log: Nuke error(...)
Summary

error(...) has many issues:

  • It is often used in the context of return error(...), implying that it has a "fancy" type, creating confusion with util::Result/Error
  • -logsourcelocations does not work with it, because it will pretend the error happened inside of logging.h
  • The log line contains ERROR: , as opposed to [error], like for other errors logged with LogError.

Fix all issues by removing it.

This is a backport of core#29236

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Fri, Nov 21, 11:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 21, 11:09
teamcity edited the summary of this revision. (Show Details)Fri, Nov 21, 11:09
PiRK published this revision for review.Fri, Nov 21, 11:12
Harbormaster completed remote builds in B35136: Diff 56713.Fri, Nov 21, 11:28
Fabien accepted this revision.Fri, Nov 21, 12:29
This revision is now accepted and ready to land.Fri, Nov 21, 12:29
Closed by commit rABC3a3d9942a46d: log: Nuke error(...) (authored by PiRK). · Explain WhyFri, Nov 21, 14:38
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3a3d9942a46d: log: Nuke error(...).

Revision Contents
Changeset List

PathSize
src/
16 lines
9 lines
index/
4 lines
57 lines
40 lines
12 lines
kernel/
3 lines
5 lines
7 lines
50 lines
node/
76 lines
script/
5 lines
13 lines
util/
5 lines
102 lines

Diff 56713

View Options

src/addrdb.cpp

Loading...
View Options

src/flatfile.cpp

Loading...
View Options

src/index/base.cpp

Loading...
View Options

src/index/blockfilterindex.cpp

Loading...
View Options

src/index/coinstatsindex.cpp

Loading...
View Options

src/index/txindex.cpp

Loading...
View Options

src/kernel/coinstats.cpp

Loading...
View Options

src/logging.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/netbase.cpp

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/script/signingprovider.cpp

Loading...
View Options

src/txdb.cpp

Loading...
View Options

src/util/fs_helpers.cpp

Loading...
View Options

src/validation.cpp

Loading...