Differential D18989

[electrum] fix unit for proof editor
AcceptedPublic
Actions

Authored by PiRK on Mon, Nov 24, 15:37.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Summary

The "select coins in wallet" widget showed "sats" when the amounts where actually formatted as "XEC". Let's just respect the unit selected by the user (default XEC).
Print whitespaces in case the user has not selected full precision in the settings (e.g unit XEC and num_zeros 0 or 1) so that the integer parts align vertically in the amount column, the same way it is already done in the Coins tab.

Depends on D18988

Test Plan

open the proof editor via the menu and via the coins tab (context menu when clicking on a utxo). Try to load additional coins from the wallet.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

proof_editor_nits

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35151
Build 69760: Build Diff	electrum-functional-tests · electrum-tests
Build 69759: arc lint + arc unit

Event Timeline

PiRK created this revision.Mon, Nov 24, 15:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 24, 15:37

additional linting

Harbormaster completed remote builds in B35150: Diff 56739.Mon, Nov 24, 15:46

Harbormaster completed remote builds in B35151: Diff 56740.

PiRK added a child revision: D18990: [electrum] enable sorting when selecting utxos for a proof.Mon, Nov 24, 16:11

Fabien accepted this revision.Mon, Nov 24, 20:48

This revision is now accepted and ready to land.Mon, Nov 24, 20:48

Revision Contents
Changeset List

Path

Size

electrum/

electrumabc_gui/

qt/

avalanche/

proof_editor.py

47 lines

4 lines

1 line

Diff 56740

electrum/electrumabc_gui/qt/avalanche/proof_editor.py

Loading...

electrum/electrumabc_gui/qt/main_window.py

Loading...

electrum/electrumabc_gui/qt/utxo_list.py

Loading...