Page MenuHomePhabricator

[electrum] enable sorting when selecting utxos for a proof
AcceptedPublic

Authored by PiRK on Mon, Nov 24, 16:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary

For wallets with many coins this can help with finding the coins to add to an avalanche proof, by sorting by amount or block height.
Depends on D18989

Test Plan

try the proof editor, add and remove coins, click the column headers to select a sorting column and toggle ascending and descending order

Diff Detail

Repository
rABC Bitcoin ABC
Branch
proof_editor_nits
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35153
Build 69764: Build Diffelectrum-functional-tests · electrum-tests
Build 69763: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Mon, Nov 24, 16:11

back out blank line change and pointless sorting enabling in init (we need to enable it only after filling the table, or else the sorting will mess with the row number as we fill the block height and add the delete button))

See https://doc.qt.io/qt-6/qtablewidget.html#setItem:

Note that if sorting is enabled (see sortingEnabled) and column is the current sort column, the row will be moved to the sorted position determined by item.

If you want to set several items of a particular row (say, by calling setItem() in a loop), you may want to turn off sorting before doing so, and turn it back on afterwards; this will allow you to use the same row argument for all items in the same row (i.e. setItem() will not move the row).

This revision is now accepted and ready to land.Mon, Nov 24, 20:49