Page MenuHomePhabricator
Differential D1916

Add query options to listunspent rpc call
ClosedPublic
Actions

Authored by deadalnix on Oct 10 2018, 15:16.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf40db5dbe186: Add query options to listunspent rpc call
rABCf40db5dbe186: Add query options to listunspent rpc call
Summary

This is a backport of Core PR8952

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
listunspentrpc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3576
Build 5227: Bitcoin ABC Buildbot (legacy)
Build 5226: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 10 2018, 15:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 10 2018, 15:16
teamcity added a subscriber: teamcity.Oct 10 2018, 15:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 5380.Oct 10 2018, 15:21

nits

teamcity added a comment.Oct 10 2018, 15:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 10 2018, 15:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3576: Diff 5379.Oct 10 2018, 15:28
teamcity added a comment.Oct 10 2018, 15:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3577: Diff 5380.Oct 10 2018, 15:33
jasonbcox accepted this revision.Oct 11 2018, 00:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/rpcwallet.cpp
3180 ↗(On Diff #5380)

This statement is missing the request.params.size() > 4 && like the previous params checks.

This revision is now accepted and ready to land.Oct 11 2018, 00:18
deadalnix marked an inline comment as done.Oct 11 2018, 10:46
deadalnix added inline comments.
src/wallet/rpcwallet.cpp
3180 ↗(On Diff #5380)

Yes, it was changed later on and I merged that :)

deadalnix updated this revision to Diff 5385.Oct 11 2018, 11:00

rebase and fix conflicts

teamcity added a comment.Oct 11 2018, 11:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3579: Diff 5385.Oct 11 2018, 11:11
teamcity added a comment.Oct 11 2018, 11:11

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCf40db5dbe186: Add query options to listunspent rpc call (authored by Pedro Branco <pedrobrancolcc@gmail.com>, committed by deadalnix). · Explain WhyOct 11 2018, 13:39
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line
wallet/
76 lines
7 lines
72 lines

Diff 5379

View Options

src/rpc/client.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...