Page MenuHomePhabricator

Clean up addrman_tests.cpp
ClosedPublic

Authored by Fabien on Oct 21 2018, 16:47.

Details

Summary

Backport from core PR 10371

Test Plan
./src/test/test_bitcoin -t addrman_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Oct 21 2018, 16:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 16:47
Fabien updated this revision to Diff 5484.Oct 21 2018, 17:32

Rebase to cleanup the stack

Fabien updated this revision to Diff 5486.Oct 21 2018, 18:11

Rebase after amend

deadalnix requested changes to this revision.Oct 21 2018, 19:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/addrman_tests.cpp
110 ↗(On Diff #5483)

There is no test 4 in the original PR, there is something wrong here. Where does this 4 come from ?

123 ↗(On Diff #5483)

You forgot to backport here

130 ↗(On Diff #5483)

dito

This revision now requires changes to proceed.Oct 21 2018, 19:11
Fabien updated this revision to Diff 5490.Oct 21 2018, 19:44

Clean stack

deadalnix requested changes to this revision.Oct 21 2018, 19:52

Almost there

src/test/addrman_tests.cpp
114 ↗(On Diff #5490)

You forgot that one.

118 ↗(On Diff #5490)

dito

120 ↗(On Diff #5490)

dito

127 ↗(On Diff #5490)

dito

This revision now requires changes to proceed.Oct 21 2018, 19:52
Fabien updated this revision to Diff 5492.Oct 21 2018, 20:12

Fix as per review

deadalnix accepted this revision.Oct 21 2018, 21:49
This revision is now accepted and ready to land.Oct 21 2018, 21:49
This revision was automatically updated to reflect the committed changes.