Page MenuHomePhabricator

Clean up addrman_tests.cpp
ClosedPublic

Authored by Fabien on Oct 21 2018, 16:47.

Details

Summary

Backport from core PR 10371

Test Plan
./src/test/test_bitcoin -t addrman_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanupaddrman
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3652
Build 5379: Bitcoin ABC Buildbot (legacy)
Build 5378: arc lint + arc unit

Event Timeline

Rebase to cleanup the stack

deadalnix requested changes to this revision.Oct 21 2018, 19:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/addrman_tests.cpp
110 ↗(On Diff #5483)

There is no test 4 in the original PR, there is something wrong here. Where does this 4 come from ?

123 ↗(On Diff #5483)

You forgot to backport here

130 ↗(On Diff #5483)

dito

This revision now requires changes to proceed.Oct 21 2018, 19:11
deadalnix requested changes to this revision.Oct 21 2018, 19:52

Almost there

src/test/addrman_tests.cpp
114

You forgot that one.

118

dito

120

dito

127

dito

This revision now requires changes to proceed.Oct 21 2018, 19:52
This revision is now accepted and ready to land.Oct 21 2018, 21:49
This revision was automatically updated to reflect the committed changes.