Page MenuHomePhabricator
Differential D1955

Clean up addrman_tests.cpp
ClosedPublic
Actions

Authored by Fabien on Oct 21 2018, 16:47.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING6e55330876e6: Clean up addrman_tests.cpp
rABC6e55330876e6: Clean up addrman_tests.cpp
Summary

Backport from core PR 10371

Test Plan
./src/test/test_bitcoin -t addrman_tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cleanupaddrman
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3652
Build 5379: Bitcoin ABC Buildbot (legacy)
Build 5378: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 21 2018, 16:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 16:47
teamcity added a subscriber: teamcity.Oct 21 2018, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 16:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3645: Diff 5483.Oct 21 2018, 16:57
Fabien updated this revision to Diff 5484.Oct 21 2018, 17:32

Rebase to cleanup the stack

teamcity added a comment.Oct 21 2018, 17:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added a child revision: D1954: Fix spurious addrman test failure.Oct 21 2018, 17:36
teamcity added a comment.Oct 21 2018, 17:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3646: Diff 5484.Oct 21 2018, 17:42
Fabien updated this revision to Diff 5486.Oct 21 2018, 18:11

Rebase after amend

teamcity added a comment.Oct 21 2018, 18:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 18:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3648: Diff 5486.Oct 21 2018, 18:21
deadalnix requested changes to this revision.Oct 21 2018, 19:11
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/test/addrman_tests.cpp
110 ↗(On Diff #5483)

There is no test 4 in the original PR, there is something wrong here. Where does this 4 come from ?

123 ↗(On Diff #5483)

You forgot to backport here

130 ↗(On Diff #5483)

dito

This revision now requires changes to proceed.Oct 21 2018, 19:11
Fabien updated this revision to Diff 5490.Oct 21 2018, 19:44

Clean stack

teamcity added a comment.Oct 21 2018, 19:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix requested changes to this revision.Oct 21 2018, 19:52

Almost there

src/test/addrman_tests.cpp
114

You forgot that one.

118

dito

120

dito

127

dito

This revision now requires changes to proceed.Oct 21 2018, 19:52
teamcity added a comment.Oct 21 2018, 19:54

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3652: Diff 5490.Oct 21 2018, 19:54
Fabien updated this revision to Diff 5492.Oct 21 2018, 20:12

Fix as per review

teamcity added a comment.Oct 21 2018, 20:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Oct 21 2018, 20:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3654: Diff 5492.Oct 21 2018, 20:22
deadalnix accepted this revision.Oct 21 2018, 21:49
This revision is now accepted and ready to land.Oct 21 2018, 21:49
Closed by commit rABC6e55330876e6: Clean up addrman_tests.cpp (authored by Jimmy Song <jaejoon@gmail.com>, committed by Fabien). · Explain WhyOct 22 2018, 11:37
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
test/
168 lines

Diff 5490

View Options

src/test/addrman_tests.cpp

Loading...