Differential D1966

Make tabs toolbar no longer have a context menu
ClosedPublic
Actions

Authored by jasonbcox on Oct 23 2018, 23:42.

Details

Reviewers

deadalnix
schancel

Group Reviewers

Restricted Project

Commits

rSTAGING6900e805a862: Make tabs toolbar no longer have a context menu
rABC6900e805a862: Make tabs toolbar no longer have a context menu

Summary

Adds a contextMenuPolicy of Qt::PreventContextMenu to prevent the
tabs toolbar from showing a context menu that allows it to be
hidden.

Backport of Core PR11169
Completes T443

Test Plan

ninja

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr11169

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3672
Build 5419: Bitcoin ABC Buildbot (legacy)
Build 5418: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 23 2018, 23:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 23 2018, 23:42

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B3672: Diff 5521.Oct 23 2018, 23:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Same as D1963, D1964 and D1965, you need to update description.

This revision now requires changes to proceed.Oct 24 2018, 23:26

jasonbcox requested review of this revision.Oct 25 2018, 00:57

jasonbcox edited the summary of this revision. (Show Details)

schancel accepted this revision.Oct 25 2018, 20:32

deadalnix accepted this revision.Oct 25 2018, 22:00

This revision is now accepted and ready to land.Oct 25 2018, 22:00

Closed by commit rABC6900e805a862: Make tabs toolbar no longer have a context menu (authored by Andrew Chow <achow101-github@achow101.com>, committed by jasonbcox). · Explain WhyOct 25 2018, 22:20

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

1 line

Diff 5521

View Options

Make tabs toolbar no longer have a context menuClosedPublicActions