Differential D1981

Various small changes in p2p-fullblocktest.py
ClosedPublic
Actions

Authored by deadalnix on Oct 29 2018, 23:15.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING93da47645e06: Various small changes in p2p-fullblocktest.py
rABC93da47645e06: Various small changes in p2p-fullblocktest.py

Summary

Formatting and making arguments explicit (whitelist is added by default unless other argument are specified, which makes it VERY confusing and got me to lose several hours of work wondering what's up).

Test Plan

make check
./test/functional/test_runner.py p2p-fullblocktest.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

p2pref

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3714
Build 5503: Bitcoin ABC Buildbot (legacy)
Build 5502: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 29 2018, 23:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2018, 23:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3714: Diff 5574.Oct 29 2018, 23:27

jasonbcox accepted this revision.Oct 30 2018, 00:03

This revision is now accepted and ready to land.Oct 30 2018, 00:03

jasonbcox added inline comments.Oct 30 2018, 00:04

test/functional/p2p-fullblocktest.py
64	Maybe add a comment with the same explanation you provided in the diff summary.

schancel edited the summary of this revision. (Show Details)Oct 30 2018, 17:08

Closed by commit rABC93da47645e06: Various small changes in p2p-fullblocktest.py (authored by deadalnix). · Explain WhyNov 1 2018, 01:20

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

test/

functional/

p2p-fullblocktest.py

9 lines

Diff 5574

View Options

test/functional/p2p-fullblocktest.py

Various small changes in p2p-fullblocktest.pyClosedPublicActions