Page MenuHomePhabricator
Differential D2006

Ensure config variables are initalized
AcceptedPublic
Actions

Authored by schancel on Nov 6 2018, 00:45.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Summary

As per title. Depends on D1936

Test Plan
make VERBOSE=1 check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix-init
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3803
Build 5680: Bitcoin ABC Buildbot (legacy)
Build 5679: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 6 2018, 00:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2018, 00:45
teamcity added a subscriber: teamcity.Nov 6 2018, 00:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a subscriber: deadalnix.Nov 6 2018, 00:51
deadalnix added inline comments.
src/config.cpp
13 ↗(On Diff #5659)

This probably shouldn't be zero. What's the default value ?

Harbormaster completed remote builds in B3776: Diff 5659.Nov 6 2018, 00:56
teamcity added a comment.Nov 6 2018, 00:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel updated this revision to Diff 5691.Nov 7 2018, 02:46

Fix default initializers

teamcity added a comment.Nov 7 2018, 02:48

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 7 2018, 02:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3803: Diff 5691.Nov 7 2018, 02:56
jasonbcox accepted this revision.Dec 21 2018, 01:48
This revision is now accepted and ready to land.Dec 21 2018, 01:48

Revision Contents
Changeset List

PathSize
src/
4 lines
4 lines

Diff 5691

View Options

src/config.cpp

Loading...
View Options

src/init.cpp

Loading...