Page MenuHomePhabricator
Differential D2010

Migrate test framework from deprecated optparse to argparse
ClosedPublic
Actions

Authored by Fabien on Nov 6 2018, 16:00.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Maniphest Tasks
T463: Switch test_framework.py not to use deprecated OptionParser
Commits
rSTAGING312a99a9d913: Migrate test framework from deprecated optparse to argparse
rABC312a99a9d913: Migrate test framework from deprecated optparse to argparse
Summary

Closes T463

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
T463
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3785
Build 5644: Bitcoin ABC Buildbot (legacy)
Build 5643: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 6 2018, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 6 2018, 16:00
teamcity added a subscriber: teamcity.Nov 6 2018, 16:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 6 2018, 16:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3785: Diff 5668.Nov 6 2018, 16:12
schancel accepted this revision.Nov 6 2018, 17:28
This revision is now accepted and ready to land.Nov 6 2018, 17:28
Closed by commit rABC312a99a9d913: Migrate test framework from deprecated optparse to argparse (authored by Fabien). · Explain WhyNov 6 2018, 17:52
This revision was automatically updated to reflect the committed changes.
jasonbcox mentioned this in D1961: Fixed padding and tx ordering in bip68-sequence.py post-fork.Nov 6 2018, 23:45
schancel mentioned this in D2015: [qa] fix abc-p2p-compactblocks test to use add_argument.Nov 7 2018, 00:10
schancel mentioned this in rABCc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument.Nov 7 2018, 00:27
schancel mentioned this in rSTAGINGc42521518207: [qa] fix abc-p2p-compactblocks test to use add_argument.Nov 30 2018, 21:30
Fabien mentioned this in D2408: CKeystore/CCrypter: move relevant implementation out of the header.Jan 24 2019, 14:57

Revision Contents
Changeset List

Diff 5668

View Options

test/functional/abc-mempool-accept-txn.py

Loading...
View Options

test/functional/abc-p2p-fullblocktest.py

Loading...
View Options

test/functional/p2p-acceptblock.py

Loading...
View Options

test/functional/p2p-fullblocktest.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/txn_clone.py

Loading...
View Options

test/functional/txn_doublespend.py

Loading...