Page MenuHomePhabricator

[minig] make CBlockAssembler take a mempool for unit testing.
ClosedPublic

Authored by schancel on Nov 11 2018, 23:10.

Details

Summary

Start passing in mempool into CBlockAssembler for easier unit testing.

Depends on D2058

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schancel created this revision.Nov 11 2018, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 23:10
deadalnix requested changes to this revision.Nov 11 2018, 23:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.h
155 ↗(On Diff #5755)

It's an horrible name.

Renaming the global mempool in g_mempool should be the first step here.

This revision now requires changes to proceed.Nov 11 2018, 23:24
jasonbcox accepted this revision.Nov 11 2018, 23:25
jasonbcox added a subscriber: jasonbcox.

Macro likestamp:

schancel edited the summary of this revision. (Show Details)Nov 13 2018, 04:30
schancel updated this revision to Diff 5792.Nov 13 2018, 04:38

Address feedback

deadalnix accepted this revision.Nov 21 2018, 17:26
This revision is now accepted and ready to land.Nov 21 2018, 17:26
This revision was automatically updated to reflect the committed changes.