Page MenuHomePhabricator
Differential D2048

[minig] make CBlockAssembler take a mempool for unit testing.
ClosedPublic
Actions

Authored by schancel on Nov 11 2018, 23:10.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING9f7574542264: [minig] make CBlockAssembler take a mempool for unit testing.
rABC9f7574542264: [minig] make CBlockAssembler take a mempool for unit testing.
Summary

Start passing in mempool into CBlockAssembler for easier unit testing.

Depends on D2058

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Nov 11 2018, 23:10
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 11 2018, 23:10
teamcity added a subscriber: teamcity.Nov 11 2018, 23:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 11 2018, 23:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3849: Diff 5755.Nov 11 2018, 23:21
deadalnix requested changes to this revision.Nov 11 2018, 23:24
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
src/miner.h
155 ↗(On Diff #5755)

It's an horrible name.

Renaming the global mempool in g_mempool should be the first step here.

This revision now requires changes to proceed.Nov 11 2018, 23:24
jasonbcox accepted this revision.Nov 11 2018, 23:25
jasonbcox added a subscriber: jasonbcox.

Macro likestamp:

schancel edited the summary of this revision. (Show Details)Nov 13 2018, 04:30
schancel added a parent revision: D2058: [rename only] mempool to g_mempool.
schancel updated this revision to Diff 5792.Nov 13 2018, 04:38

Address feedback

teamcity added a comment.Nov 13 2018, 04:40

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 13 2018, 04:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3882: Diff 5792.Nov 13 2018, 04:49
deadalnix accepted this revision.Nov 21 2018, 17:26
This revision is now accepted and ready to land.Nov 21 2018, 17:26
Closed by commit rABC9f7574542264: [minig] make CBlockAssembler take a mempool for unit testing. (authored by schancel). · Explain WhyNov 22 2018, 23:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
40 lines
rpc/
7 lines
test/
90 lines
2 lines
2 lines
2 lines

Diff 6046

View Options

src/miner.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/rpc/mining.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...
View Options

src/txmempool.h

Loading...
View Options

src/txmempool.cpp

Loading...