This reverts commit b86f0e99002157f8e415a5d2198d78f77612f336.
Reverts https://reviews.bitcoinabc.org/D1504
Details
Details
- Reviewers
deadalnix schancel - Group Reviewers
Restricted Project - Commits
- rSTAGINGe6b8f1969542: Revert "Cleanup unused contrib scripts"
rABCe6b8f1969542: Revert "Cleanup unused contrib scripts"
N/A. Need to fix these scripts up a bit first
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| contrib/gitian/gitian-build.sh | ||
|---|---|---|
| 34 ↗ | (On Diff #5776) | Do we know what gitian.sigs and bitcoin-detached-sigs are? |
| 189 ↗ | (On Diff #5776) | We should add downloading this during the setup phase possibly. |
| 236 ↗ | (On Diff #5776) | This seems really old. What is this for? |
| 238 ↗ | (On Diff #5776) | Some of this is explained here https://github.com/bitcoin/bitcoin/blob/master/doc/release-process.md |
| 242 ↗ | (On Diff #5776) | These are out of date now. |
| 305 ↗ | (On Diff #5776) | Why is this indented so much more? |
| 356 ↗ | (On Diff #5776) | What's going on with this formatting? |
| contrib/verifybinaries/verify.sh | ||
| 25 ↗ | (On Diff #5776) | We don't have this infrastructure setup |
| 73 ↗ | (On Diff #5776) | --decrypt??? |
| contrib/gitian/gitian-build.sh | ||
|---|---|---|
| 189 ↗ | (On Diff #5776) | Agreed. It's in our instructions to fix manually already. |
| 242 ↗ | (On Diff #5776) | Good catch. I'll fix this in a future diff |
| 305 ↗ | (On Diff #5776) | The indenting in all fucked in this file. It's a mix between tabs and spaces. Some lines even have tabs and spaces on the same line. No idea how that's even valid python... |
| 356 ↗ | (On Diff #5776) | See above |
| contrib/gitian/gitian-build.sh | ||
|---|---|---|
| 305 ↗ | (On Diff #5776) | It's not valid python, but it is valid shell... Can you please convert the tabs to spaces? |