Page MenuHomePhabricator
Differential D2066

Updates version to v0.18.5
ClosedPublic
Actions

Authored by schancel on Nov 15 2018, 17:50.

Details

Reviewers
jasonbcox
Mengerian
akb
Group Reviewers
Restricted Project
Commits
rSTAGING9b241b4087c5: Updates version to v0.18.5
rABC9b241b4087c5: Updates version to v0.18.5
Summary

As per title. Update version strings to v0.18.5

Test Plan
make check && ./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

schancel created this revision.Nov 15 2018, 17:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2018, 17:50
teamcity added a subscriber: teamcity.Nov 15 2018, 17:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

akb requested changes to this revision.Nov 15 2018, 17:53

Couple nits

doc/release-notes.md
1 ↗(On Diff #5825)

Should the file name be "release-notes-0.18.5.md"?

src/qt/intro.cpp
25 ↗(On Diff #5825)

Doesn't seem related to version bump.

This revision now requires changes to proceed.Nov 15 2018, 17:53
teamcity added a comment.Nov 15 2018, 17:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3907: Diff 5825!Nov 15 2018, 17:59
akb accepted this revision.Nov 15 2018, 18:01

Concerns allayed, carry on.

This revision is now accepted and ready to land.Nov 15 2018, 18:01
Mengerian accepted this revision.Nov 15 2018, 19:05

Looks good to me.

jasonbcox accepted this revision.Nov 16 2018, 06:04
Closed by commit rABC9b241b4087c5: Updates version to v0.18.5 (authored by schancel). · Explain WhyNov 19 2018, 02:10
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
2 lines
doc/
2 lines
5 lines
release-notes/
release-notes-0.18.4.md
release-notes.md
src/
2 lines
config/
2 lines
qt/
2 lines
test/
2 lines

Diff 5913

View Options

configure.ac

Loading...
View Options

doc/Doxyfile

Loading...
View Options

doc/release-notes.md

Loading...
View Options

doc/release-notes/release-notes-0.18.4.md

Loading...
View Options

src/clientversion.h

Loading...
View Options

src/config/CMakeLists.txt

Loading...
View Options

src/qt/intro.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...