Page MenuHomePhabricator

[qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade
ClosedPublic

Authored by jasonbcox on Mon, Nov 19, 02:55.

Details

Summary

Properly use LTOR blocks, and padded transactions.

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Nov 19, 02:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 19, 02:55
schancel retitled this revision from [WIP] Fix abc-p2p-compactblock flakiness to [WIP] Fix abc-p2p-compactblocks flakiness.Mon, Nov 19, 03:25
schancel updated this revision to Diff 5932.Mon, Nov 19, 08:18
schancel added a subscriber: schancel.

Update to create correct sized blocks

schancel updated this revision to Diff 5938.Mon, Nov 19, 09:05

Updates

jasonbcox updated this revision to Diff 5939.Mon, Nov 19, 09:28

Rebase + refactor

jasonbcox retitled this revision from [WIP] Fix abc-p2p-compactblocks flakiness to Fix abc-p2p-compactblocks flakiness.Mon, Nov 19, 09:31
schancel retitled this revision from Fix abc-p2p-compactblocks flakiness to [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade.Mon, Nov 19, 09:33
schancel edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)Mon, Nov 19, 09:34
schancel accepted this revision.Mon, Nov 19, 09:39
This revision is now accepted and ready to land.Mon, Nov 19, 09:39
This revision was automatically updated to reflect the committed changes.
deadalnix added inline comments.
test/functional/abc-p2p-compactblocks.py
134

Why is that needed ?

207

Why did this move here ?