Page MenuHomePhabricator
Differential D2094

[qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade
ClosedPublic
Actions

Authored by jasonbcox on Nov 19 2018, 02:55.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGINGdfaed8898e54: [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade
rABCdfaed8898e54: [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade
Summary

Properly use LTOR blocks, and padded transactions.

Co-authored-by: Jason B. Cox <contact@jasonbcox.com>

Test Plan

test_runner.py abc-p2p-compactblocks

Diff Detail

Repository
rABC Bitcoin ABC
Branch
abc-cb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3996
Build 6064: Bitcoin ABC Buildbot (legacy)
Build 6063: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 19 2018, 02:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 19 2018, 02:55
teamcity added a subscriber: teamcity.Nov 19 2018, 02:57

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 19 2018, 03:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3983: Diff 5920.Nov 19 2018, 03:04
schancel retitled this revision from [WIP] Fix abc-p2p-compactblock flakiness to [WIP] Fix abc-p2p-compactblocks flakiness.Nov 19 2018, 03:25
teamcity added a comment.Nov 19 2018, 03:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 19 2018, 03:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel updated this revision to Diff 5932.Nov 19 2018, 08:18
schancel added a subscriber: schancel.

Update to create correct sized blocks

teamcity added a comment.Nov 19 2018, 08:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 19 2018, 08:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3992: Diff 5932!Nov 19 2018, 08:29
schancel updated this revision to Diff 5938.Nov 19 2018, 09:05

Updates

teamcity added a comment.Nov 19 2018, 09:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 19 2018, 09:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3995: Diff 5938!Nov 19 2018, 09:15
jasonbcox updated this revision to Diff 5939.Nov 19 2018, 09:28

Rebase + refactor

teamcity added a comment.Nov 19 2018, 09:30

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox retitled this revision from [WIP] Fix abc-p2p-compactblocks flakiness to Fix abc-p2p-compactblocks flakiness.Nov 19 2018, 09:31
schancel retitled this revision from Fix abc-p2p-compactblocks flakiness to [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade.Nov 19 2018, 09:33
schancel edited the summary of this revision. (Show Details)
jasonbcox edited the summary of this revision. (Show Details)Nov 19 2018, 09:34
teamcity added a comment.Nov 19 2018, 09:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

schancel accepted this revision.Nov 19 2018, 09:39
This revision is now accepted and ready to land.Nov 19 2018, 09:39
Harbormaster completed remote builds in B3996: Diff 5939.Nov 19 2018, 09:39
Closed by commit rABCdfaed8898e54: [qa] fix abc-p2p-compactblocks to be compatible with magnetic anomaly upgrade (authored by schancel, committed by jasonbcox). · Explain WhyNov 19 2018, 09:40
This revision was automatically updated to reflect the committed changes.
deadalnix added a subscriber: deadalnix.Nov 19 2018, 11:55
deadalnix added inline comments.
test/functional/abc-p2p-compactblocks.py
134 ↗(On Diff #5940)

Why is that needed ?

207 ↗(On Diff #5940)

Why did this move here ?

Revision Contents
Changeset List

PathSize
test/
functional/
40 lines

Diff 5939

View Options

test/functional/abc-p2p-compactblocks.py

Loading...