- Group Reviewers
I would advise strongly against moving these globals around unless you can ensure that initialization will be done in proper order. Initialization across modules is linker dependent, unless you want to specify it using a linker script so they'd better not depend on each other, which I wouldn't bet on.
|427 ↗||(On Diff #6105)|
This being included in 3 libraries indicate that it's likely none of these 3 places is actually correct.
|27 ↗||(On Diff #6105)|
Now you just lost any guarantees on initialization order.
|1157 ↗||(On Diff #6105)|
The semantic isn't the same anymore. In addition it doesn't look like any of the changes int hat file is related to the diff.
|18 ↗||(On Diff #6105)|
Why twice ?