Page MenuHomePhabricator

[wip] Move primary globals to globals.h

Authored by schancel on Nov 26 2018, 19:16.


Group Reviewers
Restricted Project
Test Plan
make check

Diff Detail

rABC Bitcoin ABC
arcpatch-D2135 (branched from master)
Lint OK
No Unit Test Coverage
Build Status
Buildable 4148
Build 6367: Bitcoin ABC Teamcity Staging
Build 6366: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 26 2018, 19:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2018, 19:16
deadalnix requested changes to this revision.Nov 27 2018, 13:50
deadalnix added a subscriber: deadalnix.

I would advise strongly against moving these globals around unless you can ensure that initialization will be done in proper order. Initialization across modules is linker dependent, unless you want to specify it using a linker script so they'd better not depend on each other, which I wouldn't bet on.

427 ↗(On Diff #6105)

This being included in 3 libraries indicate that it's likely none of these 3 places is actually correct.

27 ↗(On Diff #6105)

Now you just lost any guarantees on initialization order.

1157 ↗(On Diff #6105)

The semantic isn't the same anymore. In addition it doesn't look like any of the changes int hat file is related to the diff.

18 ↗(On Diff #6105)

Why twice ?

This revision now requires changes to proceed.Nov 27 2018, 13:50
schancel updated this revision to Diff 6137.Nov 27 2018, 18:21

Minor cleanup. Still doenst' link

schancel marked an inline comment as done.Nov 27 2018, 18:23
schancel added inline comments.
427 ↗(On Diff #6105)

Indeed. I'm having trouble with getting it to link. Not sure why:

schancel planned changes to this revision.Nov 28 2018, 16:45
schancel abandoned this revision.Nov 30 2018, 21:55