Page MenuHomePhabricator

Fix some nits in bip68-112-113-p2p.py
ClosedPublic

Authored by Fabien on Nov 28 2018, 12:31.

Details

Summary
  • Remove BytesIO dependency
  • Refactor comments layout
  • Fix test numbering
Test Plan
./test/functional/test_runner.py bip68-112-113-p2p

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Nov 28 2018, 17:16
schancel added inline comments.
test/functional/bip68-112-113-p2p.py
360 ↗(On Diff #6151)

I guess some tests were lost? Can I ask that you possibly add "Test #3" I was a bit confused as to what the comment was for.

Make test numbering comments more explicit

This revision was automatically updated to reflect the committed changes.