Page MenuHomePhabricator

Fix some nits in bip68-112-113-p2p.py
ClosedPublic

Authored by Fabien on Wed, Nov 28, 12:31.

Details

Summary
  • Remove BytesIO dependency
  • Refactor comments layout
  • Fix test numbering
Test Plan
./test/functional/test_runner.py bip68-112-113-p2p

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Nov 28, 12:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 28, 12:31
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Wed, Nov 28, 17:16
This revision is now accepted and ready to land.Wed, Nov 28, 17:16
schancel accepted this revision.Wed, Nov 28, 17:40
schancel added inline comments.
test/functional/bip68-112-113-p2p.py
360 ↗(On Diff #6151)

I guess some tests were lost? Can I ask that you possibly add "Test #3" I was a bit confused as to what the comment was for.

Fabien updated this revision to Diff 6163.Thu, Nov 29, 15:05

Make test numbering comments more explicit

This revision was automatically updated to reflect the committed changes.