Page MenuHomePhabricator
Differential D2146

Fix some nits in bip68-112-113-p2p.py
ClosedPublic
Actions

Authored by Fabien on Nov 28 2018, 12:31.

Details

Reviewers
deadalnix
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING3bb7c6c992ee: Fix some nits in bip68-112-113-p2p.py
rABC3bb7c6c992ee: Fix some nits in bip68-112-113-p2p.py
Summary
  • Remove BytesIO dependency
  • Refactor comments layout
  • Fix test numbering
Test Plan
./test/functional/test_runner.py bip68-112-113-p2p

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Nov 28 2018, 12:31
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 28 2018, 12:31
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Nov 28 2018, 12:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 28 2018, 12:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4157: Diff 6151.Nov 28 2018, 12:43
deadalnix accepted this revision.Nov 28 2018, 17:16
This revision is now accepted and ready to land.Nov 28 2018, 17:16
schancel accepted this revision.Nov 28 2018, 17:40
schancel added inline comments.
test/functional/bip68-112-113-p2p.py
360 ↗(On Diff #6151)

I guess some tests were lost? Can I ask that you possibly add "Test #3" I was a bit confused as to what the comment was for.

Fabien updated this revision to Diff 6163.Nov 29 2018, 15:05

Make test numbering comments more explicit

teamcity added a comment.Nov 29 2018, 15:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Nov 29 2018, 15:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4166: Diff 6163.Nov 29 2018, 15:16
Closed by commit rABC3bb7c6c992ee: Fix some nits in bip68-112-113-p2p.py (authored by Fabien). · Explain WhyNov 29 2018, 16:33
This revision was automatically updated to reflect the committed changes.
Fabien added a child revision: D2176: Move OP_CSV from scriptSig to scriptPubKey in bip68-112-113-p2p.Dec 4 2018, 15:30

Revision Contents
Changeset List

PathSize
test/
functional/
89 lines

Diff 6166

View Options

test/functional/bip68-112-113-p2p.py

Loading...