[avalanche] Fix inconsistent numeric types
ClosedPublic
Actions

Authored by vermorel on Dec 3 2018, 21:16.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING675e548f02c5: [avalanche] Fix inconsistent numeric types
rABC675e548f02c5: [avalanche] Fix inconsistent numeric types

Summary

Method arguments are aligned type-wise with their member type counterparts.

Test Plan

did rebuild and rerun unit tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ava-uint64

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4261
Build 6587: Bitcoin ABC Buildbot (legacy)
Build 6586: arc lint + arc unit

Event Timeline

vermorel created this revision.Dec 3 2018, 21:16

Owners added a reviewer: Restricted Owners Package.Dec 3 2018, 21:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 3 2018, 21:16

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4261: Diff 6271.Dec 3 2018, 21:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Dec 3 2018, 21:59

This revision is now accepted and ready to land.Dec 3 2018, 21:59

Closed by commit rABC675e548f02c5: [avalanche] Fix inconsistent numeric types (authored by vermorel). · Explain WhyDec 4 2018, 15:32

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

avalanche.h

4 lines

avalanche.cpp

2 lines

Diff 6271

View Options

src/avalanche.h