Page MenuHomePhabricator
Differential D2186

Minor doc update, clarifying intent of 'CInv'
ClosedPublic
Actions

Authored by vermorel on Dec 11 2018, 08:20.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe02aa01cfaaa: Minor doc update, clarifying intent of 'CInv'
rABCe02aa01cfaaa: Minor doc update, clarifying intent of 'CInv'
Test Plan

comment only, code untouched

Diff Detail

Repository
rABC Bitcoin ABC
Branch
protocol-doc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4305
Build 6675: Bitcoin ABC Buildbot (legacy)
Build 6674: arc lint + arc unit

Event Timeline

vermorel created this revision.Dec 11 2018, 08:20
Owners added a reviewer: Restricted Owners Package.Dec 11 2018, 08:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 11 2018, 08:20
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Dec 11 2018, 08:20

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 11 2018, 08:29

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4302: Diff 6328.Dec 11 2018, 08:29
deadalnix requested changes to this revision.Dec 11 2018, 16:58
deadalnix added inline comments.
src/protocol.h
421 ↗(On Diff #6328)

Please fix the formatting.

/**
 * Inv(ventory) message data
 * Intended as non-ambiguous identifier of objects (eg. transactions, blocks)
 * held by peers.
 */
This revision now requires changes to proceed.Dec 11 2018, 16:58
vermorel updated this revision to Diff 6333.Dec 12 2018, 20:40

Fix formatting

teamcity added a comment.Dec 12 2018, 20:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4305: Diff 6333.Dec 12 2018, 20:52
teamcity added a comment.Dec 12 2018, 20:52

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix requested changes to this revision.Dec 14 2018, 08:06
deadalnix added inline comments.
src/protocol.h
422

The formatting is still screwed up.

This revision now requires changes to proceed.Dec 14 2018, 08:06
vermorel updated this revision to Diff 6371.Dec 19 2018, 19:58

Fix formatting

jasonbcox accepted this revision.Dec 19 2018, 23:55
teamcity added a comment.Dec 20 2018, 01:26

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Dec 20 2018, 01:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4330: Diff 6371.Dec 20 2018, 01:34
deadalnix accepted this revision.Dec 20 2018, 12:44
This revision is now accepted and ready to land.Dec 20 2018, 12:44
Closed by commit rABCe02aa01cfaaa: Minor doc update, clarifying intent of 'CInv' (authored by vermorel). · Explain WhyDec 20 2018, 13:44
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
6 lines

Diff 6333

View Options

src/protocol.h

Loading...