Page MenuHomePhabricator

Avoid redundant redeclaration of GetWarnings(const string&)
ClosedPublic

Authored by Fabien on Dec 17 2018, 09:25.

Details

Summary

std::string GetWarnings(const std::string& strFor) is declared in
warnings.h and validation.h, and defined in warnings.cpp.

Backport of core PR10864

Test Plan

Run with the -testsafemode=1 argument and check the warning appears

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Dec 17 2018, 09:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2018, 09:25
Herald added a subscriber: schancel. · View Herald Transcript
Fabien edited the test plan for this revision. (Show Details)Dec 17 2018, 13:30
jasonbcox accepted this revision.Dec 18 2018, 00:18
This revision is now accepted and ready to land.Dec 18 2018, 00:18
Closed by commit rABC101b9aa6ebc0: Avoid redundant redeclaration of GetWarnings(const string&) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain WhyDec 19 2018, 10:57
This revision was automatically updated to reflect the committed changes.